[Kibana Integration Testing] Update workflows to run one after another and add CI status checking#9723
Merged
Merged
Conversation
…kibana_dependencies__prepare_changes.yml`
2 visual difference(s) found - expand to review, then click Approve visual changes to update baselineseuipopover (1 difference)
euidatagrid (1 difference)
|
1 task
Collaborator
💚 Build Succeeded
History
cc @tkajtoch |
Member
Author
|
Test |
17 tasks
| check_ci_status_1: | ||
| name: Check CI status - attempt 1/2 | ||
| runs-on: ubuntu-slim | ||
| environment: delayed-2h |
Contributor
There was a problem hiding this comment.
A good trick! 👍🏻
weronikaolejniczak
approved these changes
Jun 19, 2026
Contributor
There was a problem hiding this comment.
This cannot be tested now because of the GH ephemeral tokens, so I'm fine merging to main as-is and fixing any issues as they arise. 🟢
Some thoughts after reading through the diff:
- Should we add concurrency and
cancel-in-progress: trueso that there can always be only one run in progress? We could group them by the source PR number. I wonder if this would also cancel the probe environments, I believe it should 🤔 - This is more work but I wonder if we could have a cleanup workflow on:
closed,unlabeled. It could cancel the workflow runs and close the Kibana PR. Or another idea is a cron that deletes branches older than N. - Could we surface the Buildkite job links in the comment body? "Failing checks" section. This would give an overview of what went wrong without having to go to the Kibana PR. This is already fetched in
link:gh pr checks --required --json name,link,bucket, no? - After calling
gh pr comment "$PR_URL" --body "/ci", this could fail due to auth or race condition or wrong reference or GH outage, whatever, never triggering the CI and the env silently sitting would finally report checks pending, maybe we could somehow surface that error in a comment so that the PR author can go and trigger the CI manually. - If
open_prfails we can delete the branch on theeui-kibanafork inline (or as part of the cleanup workflow). - As we talked, I believe 1h and 2h is enough but we can start with 2h and 4h, and see how it goes.
Member
Author
|
These are all great points @weronikaolejniczak! I purposefully limited the scope of this to see if we can get it working first, but I agree that we need a cleanup job, concurrency setup and a way to re-test in Kibana when new changes are added to EUI PRs. I suspect we might encounter issues during testing, and I'm ready to fix them all! :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.






Summary
This PR updates the Kibana regression integration testing workflows to:
update_kibana_dependencies__open_pr.ymlat the end ofupdate_kibana_dependencies__prepare_changes.yml/cicommentThe PR label trigger on EUI PRs and commenting the status of Kibana CI will be added separately.
API Changes
N/A
Screenshots
N/A
Impact Assessment
Note: Most PRs should be tested in Kibana to help gauge their Impact before merging.
🔴 Breaking changes — What will break? How many usages in Kibana/Cloud UI are impacted?💅 Visual changes — May impact style overrides; could require visual testing. Explain and estimate impact.🧪 Test impact — May break functional or snapshot tests (e.g., HTML structure, class names, default values).🔧 Hard to integrate — If changes require substantial updates to Kibana, please stage the changes and link them here.Impact level: 🟢 None
Release Readiness
Documentation: {link to docs page(s)}Figma: {link to Figma or issue}Migration guide: {steps or link, for breaking/visual changes or deprecations}Adoption plan (new features): {link to issue/doc or outline who will integrate this and where}QA instructions for reviewer
These changes are not possible to be run prior to merging due to the token policy restricting us from running workflows from branches other than
main.Checklist before marking Ready for Review
QA: Tested light/dark modes, high contrast, mobile, Chrome/Safari/Edge/Firefox, keyboard-only, screen readerQA: Tested in CodeSandbox and KibanaQA: Tested docs changesTests: Added/updated Jest, Cypress, and VRTChangelog: Added changelog entryBreaking changes: Addedbreaking changelabel (if applicable)Reviewer checklist