[Chore] Run only relevant tests#9687
Draft
weronikaolejniczak wants to merge 5 commits into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Buildkite PR test pipeline to (1) selectively skip the heavy EUI test suite when a PR only touches non-EUI paths, and (2) add package-scoped CI steps for the ESLint plugin and EUI theme packages.
Changes:
- Add path-based early-exit logic in
pipeline_test.shfor heavy EUI jobs (lint/unit/cypress) when only non-EUI areas changed. - Expand Buildkite PR trigger “skip CI on only changed paths” to include website and Docusaurus packages.
- Add new PR pipeline steps to run unit/lint tasks for
@elastic/eslint-plugin-eui,@elastic/eui-theme-common, and@elastic/eui-theme-borealis.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .buildkite/scripts/pipelines/pipeline_test.sh | Adds non-EUI path detection and new per-package test/lint task types. |
| .buildkite/pull-requests.json | Extends “skip CI on only changed paths” to website & docusaurus packages. |
| .buildkite/pipelines/pipeline_pull_request_test.yml | Adds new Buildkite steps for eslint-plugin and theme package lint/unit tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # When a PR's diff is contained entirely within these paths, | ||
| # the heavy EUI jobs (lint, unit:*, cypress:*) exit early below. | ||
| # The lightweight per-package jobs always run. | ||
| NON_EUI_PATHS_REGEXP='^(\.github/|wiki/|packages/(website|docusaurus-[^/]+|eslint-plugin)/)' |
Contributor
Author
There was a problem hiding this comment.
In theory, these will be skipped earlier. This is an additional check.
2 tasks
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
weronikaolejniczak
force-pushed
the
chore/relevant-tests
branch
from
cca3538 to
7de40e0
Compare
Collaborator
💔 Build Failed
Failed CI StepsHistory
|
3 visual difference(s) found - expand to review, then click Approve visual changes to update baselineseuicodeblock (1 difference)
euipopover (1 difference)
euidatagrid (1 difference)
|
Collaborator
💔 Build Failed
Failed CI StepsHistory
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes https://github.com/elastic/eui-private/issues/451
The idea here is to add the missing Jest test suites to the CI and skip all the heavy EUI testing when we know the changes don't affect it (ESLint plugin, website, wiki etc.). Apparently, our CI cost is very low so the argument for this is mostly to save on our time.
The Dream™ would be a job per package (linting, Jest tests, E2E tests) but this requires a bigger CI re-architecture.
QA instructions for reviewer
.github/,wiki/,packages/website/,packages/docusaurus-theme/orpackages/docusaurus-preset/skips the whole test pipeline.packages/eslint-plugin/skips the EUI jobs but still runsWorkspace unit testsandWorkspace linting.packages/eui-theme-borealis/orpackages/eui-theme-common/still runs the full EUI suite plus the workspace jobs.