[ES|QL] Support for First/Last (#137408) - Code Gen & ALL_LAST #138066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
v9.3.0
needs:triage
Contributor
Author
|
Two things I know are missing that I will get to eventually in another PR.
|
mouhc1ne
added
>enhancement
Team:Analytics
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
elasticsearchmachine
removed
the
needs:triage
- Minor refactoring in "build.gradle" to allow the generation of the two variants of state classes (e.g.: LongLongState and AllLongLongState) - Generate the new two state files using "All-X-2State.java.st", for all types. - Generate the new timestamp aggregator files using "All-X-ValueByTimestampAggregator.java.st", for all types. - Register ALL_LAST as snapshot function - Augment existing csv tests to exercise ALL_LAST as well, and to check for all supported types.
Member
We've been starting all templates with |
ncordon
pushed a commit
to ncordon/elasticsearch
that referenced
this pull request
Nov 26, 2025
…elastic#138066) - Minor refactoring in "build.gradle" to allow the generation of the two variants of state classes (e.g.: LongLongState and AllLongLongState) - Generate the new two state files using "All-X-2State.java.st", for all types. - Generate the new timestamp aggregator files using "All-X-ValueByTimestampAggregator.java.st", for all types. - Register ALL_LAST as snapshot function - Augment existing csv tests to exercise ALL_LAST as well, and to check for all supported types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build.gradleto allow the generation of the two variants of state classes (e.g.:LongLongStateandAllLongLongState)All-X-2State.java.st, for all types.All-X-ValueByTimestampAggregator.java.st, for all types.ALL_LASTas snapshot functionALL_LASTas well, and to check for all supported types.