Skip to content

Conversation

@ankit--sethi
Copy link
Contributor

The current version is 4 years old; newer versions have substantive improvements to connection pooling and health check behavior.

@ankit--sethi ankit--sethi requested a review from a team as a code owner November 13, 2025 19:31
@ankit--sethi ankit--sethi added the :Security/Security Security issues without another label label Nov 13, 2025
@elasticsearchmachine elasticsearchmachine added Team:Security Meta label for security team v9.3.0 labels Nov 13, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-security (Team:Security)

@ankit--sethi ankit--sethi added >bug and removed Team:Security Meta label for security team v9.3.0 labels Nov 13, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Security Meta label for security team label Nov 13, 2025
@ankit--sethi ankit--sethi added auto-backport Automatically create backport pull requests when merged v9.0.9 v9.2.2 v8.19.8 v9.1.8 and removed Team:Security Meta label for security team labels Nov 13, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Security Meta label for security team label Nov 13, 2025
@elasticsearchmachine
Copy link
Collaborator

Hi @ankit--sethi, I've created a changelog YAML for you.

@ankit--sethi ankit--sethi requested a review from a team November 13, 2025 21:41
@elasticsearchmachine
Copy link
Collaborator

Hi @ankit--sethi, I've updated the changelog YAML for you.

Copy link
Contributor

@piotrsulkowski-elastic piotrsulkowski-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Mind that normally I wouldn't approve anything yet, as I'm pretty new, but this change does seem fairly uncontroversial and safe.

I'm actually surprised that it fixes the mentioned issue, but if it does, then great! I imagine that in the most common scenario of single connection being broken, the new strategy to wait until a new connection is created (instead of trying another one from the pool) is slower, however the benefits seem to outweigh that problem. It seems that the main benefit is being able to detect broken servers promptly and return a good connection, as opposed to circulating through different servers, some of them being shut down, erroring each time until they timeout on some arbitrary ttl. From the release notes, it sounds to me more like an accidental improvement, but as you mentioned earlier, it would be difficult to fix it on our side if the library didn't fix it.

@elasticsearchmachine
Copy link
Collaborator

Hi @ankit--sethi, I've updated the changelog YAML for you.

ankit--sethi and others added 2 commits November 19, 2025 14:35
Co-authored-by: Slobodan Adamović <slobodanadamovic@users.noreply.github.com>
Copy link
Contributor

@slobodanadamovic slobodanadamovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ankit--sethi ankit--sethi merged commit 6b00eea into elastic:main Nov 19, 2025
41 checks passed
ankit--sethi added a commit to ankit--sethi/elasticsearch that referenced this pull request Nov 19, 2025
ankit--sethi added a commit to ankit--sethi/elasticsearch that referenced this pull request Nov 19, 2025
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
9.0
9.2
8.19
9.1

ankit--sethi added a commit to ankit--sethi/elasticsearch that referenced this pull request Nov 19, 2025
ankit--sethi added a commit to ankit--sethi/elasticsearch that referenced this pull request Nov 19, 2025
ncordon pushed a commit to ncordon/elasticsearch that referenced this pull request Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged :Security/Security Security issues without another label Team:Security Meta label for security team >upgrade v8.19.8 v9.0.9 v9.1.8 v9.2.2 v9.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants