-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Upgrade UnboundID LDAP SDK to 7.0.3 #138053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade UnboundID LDAP SDK to 7.0.3 #138053
Conversation
|
Pinging @elastic/es-security (Team:Security) |
|
Hi @ankit--sethi, I've created a changelog YAML for you. |
|
Hi @ankit--sethi, I've updated the changelog YAML for you. |
piotrsulkowski-elastic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Mind that normally I wouldn't approve anything yet, as I'm pretty new, but this change does seem fairly uncontroversial and safe.
I'm actually surprised that it fixes the mentioned issue, but if it does, then great! I imagine that in the most common scenario of single connection being broken, the new strategy to wait until a new connection is created (instead of trying another one from the pool) is slower, however the benefits seem to outweigh that problem. It seems that the main benefit is being able to detect broken servers promptly and return a good connection, as opposed to circulating through different servers, some of them being shut down, erroring each time until they timeout on some arbitrary ttl. From the release notes, it sounds to me more like an accidental improvement, but as you mentioned earlier, it would be difficult to fix it on our side if the library didn't fix it.
|
Hi @ankit--sethi, I've updated the changelog YAML for you. |
Co-authored-by: Slobodan Adamović <slobodanadamovic@users.noreply.github.com>
slobodanadamovic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
The current version is 4 years old; newer versions have substantive improvements to connection pooling and health check behavior.