[9.1] Add back private knn_search API for rest-api-spec generation (#5737) #5770
+555
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Revert "Remove knn_search API (#4276)" This reverts commit 2a24e33 since _knn_search is still needed in rest-api-spec to run YAML tests against it, as the API is still available with v8 compatibility mode. However, we make the API private so that it does not get back into clients, as it would fail with v9 compatibility. * Add UpdateForV10 annotation * Fix lint (cherry picked from commit 709ff24) # Conflicts: # output/schema/schema.json
Contributor
|
Following you can find the validation changes against the target branch for the API.
You can validate this API yourself by using the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto9.1:Questions ?
Please refer to the Backport tool documentation