Declare the products hub prefix as a navigation phantom - #3876
Open
florent-leborgne wants to merge 1 commit into
Open
Declare the products hub prefix as a navigation phantom#3876florent-leborgne wants to merge 1 commit into
florent-leborgne wants to merge 1 commit into
Conversation
Isolated docs-content builds reject pages under prefixes that assembler navigation does not claim. A real toc entry would fail assembler until the hub pages exist on docs-content main. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Isolated docs-content builds run
NavigationPrefixCheckeragainst assembler navigation fromdocs-builder:edge. Pages under a prefix that is neither a claimedtocnor a phantom fail CI. elastic/docs-content#7964 adds hub pages at/products/*, which is a new top-level prefix.A real
- toc: productsentry would fail assembler build until those files exist on docs-contentmain(Could not find navigation node for identifier: docs-content://products).What
Registers
docs-content://productsas a phantom inconfig/navigation.ymlandconfig/navigation_preview.yml. That lets the prefix checker accept the hub pages without requiring the folder to exist on docs-contentmainyet, and without putting Products in primary nav.After elastic/docs-content#7964 merges, a follow-up can replace this phantom with
- toc: products(afterget-started) if Products should appear in primary nav.Test plan
main(noproducts/folder required)docs-builder:edge, re-run Add product documentation hub pages docs-content#7964build / build; the fourproducts/*.mdprefix-checker errors should be goneMade with Cursor