Skip to content

fix: preserve leading dots in .cceignore paths #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MDerman wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: preserve leading dots in .cceignore paths #161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/context_engine/indexer/ignorefile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ def matches_any(rel_path: str, is_dir: bool, patterns: list[str]) -> bool:
if not patterns:
return False
# Normalise: forward slashes, no leading "./"
rel = rel_path.replace("\\", "/").lstrip("./")
rel = rel_path.replace("\\", "/").removeprefix("./")
name = rel.rsplit("/", 1)[-1]
for pat in patterns:
# Trailing slash → directory-only pattern.
Expand Down
11 changes: 10 additions & 1 deletion tests/indexer/test_ignorefile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,12 @@ def test_trailing_slash_only_matches_dirs():
assert matches_any("src/build", is_dir=True, patterns=p)


def test_trailing_slash_matches_root_dot_directory():
p = [".playwright/"]
assert matches_any(".playwright", is_dir=True, patterns=p)
assert matches_any("./.playwright", is_dir=True, patterns=p)


# ── Empty / no-match guards ────────────────────────────────────────────────

def test_empty_patterns_matches_nothing():
Expand All @@ -110,18 +116,21 @@ def test_pipeline_walk_respects_cceignore(tmp_path):
(p / "trace.log").write_text("noisy\n")
(p / "scratch").mkdir()
(p / "scratch" / "data.txt").write_text("temp\n")
(p / ".playwright").mkdir()
(p / ".playwright" / "state.json").write_text("{}\n")
(p / "src").mkdir()
(p / "src" / "lib.py").write_text("def lib(): pass\n")

files = list(_iter_project_files(
p, ignore_set=set(), skip_extensions=_SKIP_EXTENSIONS,
cceignore_patterns=["*.log", "scratch/"],
cceignore_patterns=["*.log", "scratch/", ".playwright/"],
))
names = sorted(f.name for f in files)
assert "main.py" in names
assert "lib.py" in names
assert "trace.log" not in names
assert "data.txt" not in names # parent dir excluded by `scratch/`
assert "state.json" not in names


def test_pipeline_no_cceignore_means_no_filter(tmp_path):
Expand Down