Drain nodegroup: gracefully handle transient control plane failures (#7550)#8782
Open
abhishek-dalbanjan wants to merge 1 commit into
Open
Drain nodegroup: gracefully handle transient control plane failures (#7550)#8782abhishek-dalbanjan wants to merge 1 commit into
abhishek-dalbanjan wants to merge 1 commit into
Conversation
When draining nodegroups, the kubernetes api server might return transient HTTP 5xx errors like 'etcdserver: leader changed' or 'raft proposal dropped' during leadership transitions. This commit recognizes these string patterns as recoverable errors so eksctl retries evicting the pods instead of surfacing an unrecoverable failure. Fixes eksctl-io#7550 Signed-off-by: Abhishek Dalbanjan <abhishekdalbanjan1@gmail.com>
Contributor
|
Hello Abhidalbanjan 👋 Thank you for opening a Pull Request in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #7550
When draining nodegroups, the kubernetes api server might return transient HTTP 5xx errors like
etcdserver: leader changedorraft proposal droppedduring leadership transitions. Previously,eksctlwould fail the drain operation entirely when encountering these errors.This PR introduces a
isTransientControlPlaneErrorcheck to recognize these string patterns as recoverable errors insideisEvictionErrorRecoverable. This ensureseksctlcorrectly retries evicting the pods instead of surfacing an unrecoverable failure to the user.Checklist
README.md, or theuserdocsdirectory)area/nodegroup) and kind (e.g.kind/improvement)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯