Addon update: fix resolving 'latest' version (#7841)#8781
Open
abhishek-dalbanjan wants to merge 1 commit into
Open
Addon update: fix resolving 'latest' version (#7841)#8781abhishek-dalbanjan wants to merge 1 commit into
abhishek-dalbanjan wants to merge 1 commit into
Conversation
When updating an addon with 'version: latest', eksctl successfully resolved the latest version for the AWS API payload, but forgot to update the internal addon struct. This caused subsequent policy lookups to fail because they still used 'latest' instead of the resolved version. This commit updates the internal struct with the resolved version to fix the error. Fixes eksctl-io#7841 Signed-off-by: Abhishek Dalbanjan <abhishekdalbanjan1@gmail.com>
Contributor
|
Hello Abhidalbanjan 👋 Thank you for opening a Pull Request in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #7841
When updating an addon with
version: latest,eksctlcorrectly resolves the latest semantic version to send to the AWS API but fails to update the internaladdonstruct. As a result, subsequent calls, likegetRecommendedPoliciesForPodID, attempt to use"latest"instead of the resolved version, causing a failure.This PR updates the internal
addon.Versioninside theelseblock so that the resolved version is used consistently throughout theeksctl update addonexecution. It also adds a unit test to verify this behavior.Checklist
README.md, or theuserdocsdirectory)area/nodegroup) and kind (e.g.kind/improvement)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯