Open
Conversation
movpushmov
force-pushed
the
feat/v1.0.0
branch
4 times, most recently
from
77cfc49 to
86be9d9
Compare
Olovyannikov
reviewed
Mar 5, 2026
LICENSE.MD
Outdated
| @@ -0,0 +1,21 @@ | |||
| MIT License | |||
|
|
|||
| Copyright (c) 2024 Edward Gigolaev & Sergey Sova | |||
There was a problem hiding this comment.
Today is 2026.
Maybe add Edward, Sergey and a link to the community also?
Member
Author
There was a problem hiding this comment.
community? what do you mean?
There was a problem hiding this comment.
Effector contributors. For example Mantine did it
Olovyannikov
reviewed
Mar 5, 2026
| js.configs.recommended, | ||
| tseslint.configs.recommended, | ||
| tseslint.configs.recommendedTypeChecked, | ||
| eslintPluginPrettierRecommended, |
There was a problem hiding this comment.
Do we need an eslint-effector-plugin here?
Olovyannikov
reviewed
Mar 5, 2026
There was a problem hiding this comment.
Do you need help creating a Vue version?
movpushmov
added
documentation
- Point package.json URLs to effector org - Refine package description for router paths - Enable pnpm allowBuilds for esbuild - Remove duplicate assertions in path builder tests
- Point homepage to router.effector.dev, repository and bugs to effector org - Add repository.directory for core, paths, react, react-native - Extract $hasOpenedRoutes in group.ts to avoid duplicate or() in sample filters - Add react README with polyfills section (Array.prototype.at)
- Add contributors (Sergey Sova, Anton Kosykh, Zero Bias) to all packages - Add Anton Kosykh to LICENSE copyright - Add :docs, :react, :react-native, :paths, :core scripts to root package.json
Replace the deploy stub with the official Pages flow: configure-pages v5, upload-pages-artifact v4 (VitePress output at docs/.vitepress/dist), and deploy-pages v4 in a separate job with the github-pages environment. Use actions/checkout v5, cancel in-progress concurrent runs, and trigger when packages/core/package.json changes so the nav version stays in sync. Add docs/public/CNAME for router.effector.dev in the static build output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.