add uniswap url parameter & add uniswap for arbitrum #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikulas-mrva
reviewed
Mar 8, 2022
pretix_eth/network/tokens.py
Outdated
| self._set_other_token_constants() | ||
|
|
||
| def _validate_class_variables(self): | ||
| if not ( |
Collaborator
There was a problem hiding this comment.
In my opinion, using not all(self.NETWORK_IDENTIFIER, self.NETWORK_VERBOSE_NAME, self.NETWORK_UNISWAP_NAME, self.TOKEN_SYMBOL) would be a wee bit more elegant without compromising on clarity. Hope it's ok for me to chime on here! .)
Contributor
Author
There was a problem hiding this comment.
oo good idea!
Since arbitrum class inherits from L1 class, by removing the custom payment method integration, arbitrum now uses the same payment choices as L1 (which includes uniswap)
rahul-kothari
force-pushed
the
uniswap-chain-names
branch
from
a846ed1 to
7325b3a
Compare
rahul-kothari
force-pushed
the
uniswap-chain-names
branch
from
7325b3a to
b7dca1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Closes #198 and adds uniswap to arbitrum
How was it fixed?
Cute Animal Picture