Open
Conversation
The signatures for RSA were incorrect per PCKS#1. Generated new keys and signatures for EcDSA, Ed25519, and RSA. Re-did the code for wolfSSL sign and verify as well to use wc_SignatureVerify and wc_SignatureGenerate.
ruuddw
requested changes
Jan 13, 2023
ruuddw
left a comment
ruuddw
left a comment
There was a problem hiding this comment.
See comments. The PKCS#1 v1.5 fix looks good, but the change to sign/verify functions that now perform (pre)hashing as part of the functions should be reverted.
Member
|
Awaiting resolution of wolfSSL/wolfssl#5981 after which I'll remove the manual encoding and then merge. I'll also change the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The signatures for RSA were incorrect per PCKS#1. Generated new keys and signatures for EcDSA, Ed25519, and RSA. Re-did the code for wolfSSL sign and verify as well to use wc_SignatureVerify and wc_SignatureGenerate.