chore: add portal-designer to devstack #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huniafatima-99
changed the title
huniafatima-99
force-pushed
the
huniafatima/add-portal-designer-in-devstack
branch
from
8c43dbf to
173e049
Compare
huniafatima-99
force-pushed
the
huniafatima/add-portal-designer-in-devstack
branch
2 times, most recently
from
ae060a1 to
66d544a
Compare
Contributor
iamsobanjaved
left a comment
iamsobanjaved
left a comment
There was a problem hiding this comment.
This is missing the change in docker-compose.yml file. Also indicated few other possible changes.
Contributor
Author
|
@iamsobanjaved all the feedback incorporated. Please review |
huniafatima-99
force-pushed
the
huniafatima/add-portal-designer-in-devstack
branch
from
3057e37 to
5b139f5
Compare
Contributor
iamsobanjaved
left a comment
iamsobanjaved
left a comment
There was a problem hiding this comment.
An entry in check.sh file is missing.
iamsobanjaved
approved these changes
Feb 13, 2025
huniafatima-99
deleted the
huniafatima/add-portal-designer-in-devstack
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.