Skip to content

fix: force apps to wait for mysql to actually become healthy#222

Merged
pwnage101 merged 1 commit into
masterfrom
pwnage101/mysql80-healthcheck
Jun 11, 2026
Merged

fix: force apps to wait for mysql to actually become healthy#222
pwnage101 merged 1 commit into
masterfrom
pwnage101/mysql80-healthcheck

Conversation

@pwnage101

@pwnage101 pwnage101 commented Jun 10, 2026

Copy link
Copy Markdown
Member

Note in the following recording:

  1. While mysql80 is in "Waiting", some of the services are stuck in "Created".
  2. Only AFTER mysql80 progresses to "Healthy", the rest of the apps begin starting.
  3. The payoff: enterprise-access is immediately running after dev.up.
    • This is a massive UX improvement over the old experience where NONE of the apps actually started (they were always stuck on an error connecting to MySQL). ALL apps needed to be manually restarted which is extremely annoying.
Screen.Recording.2026-06-10.at.15.53.23.mov

Copilot AI review requested due to automatic review settings June 10, 2026 23:00
@pwnage101 pwnage101 changed the title feat: force apps to wait for mysql to actually become healthy fix: force apps to wait for mysql to actually become healthy Jun 10, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves devstack startup behavior by adding an explicit MySQL healthcheck and updating service dependencies so application containers wait for MySQL to become healthy (not merely started), preventing “created/stuck” states and reducing the need for manual restarts.

Changes:

  • Added a healthcheck to the mysql80 service that pings MySQL over TCP to avoid false-positives during first-time initialization.
  • Updated multiple services’ depends_on to use condition: service_healthy for mysql80 (and service_started for other dependencies) so apps start only after MySQL is actually ready.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread docker-compose.yml Outdated
@pwnage101 pwnage101 force-pushed the pwnage101/mysql80-healthcheck branch from 7cd0a08 to 2c1ac62 Compare June 10, 2026 23:05

@kiram15 kiram15 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very helpful, thank you for this change!

@pwnage101 pwnage101 merged commit 80e883b into master Jun 11, 2026
18 of 19 checks passed
@pwnage101 pwnage101 deleted the pwnage101/mysql80-healthcheck branch June 11, 2026 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants