Skip to content

Chore: rever to old enterprise.catalog.app name to sync with other configs #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
macdiesel merged 1 commit into from
Oct 22, 2025
Merged

Chore: rever to old enterprise.catalog.app name to sync with other configs #189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -742,8 +742,8 @@ services:

enterprise-catalog:
image: edxops/enterprise-catalog-dev
container_name: edx.devstack.enterprise-catalog
hostname: enterprise-catalog.devstack.edx
container_name: enterprise.catalog.app
hostname: enterprise.catalog.app
command: bash -c 'while true; do python /edx/app/enterprise-catalog/manage.py runserver 0.0.0.0:18160; sleep 2; done'
ports:
- "18160:18160"
Expand Down
2 changes: 1 addition & 1 deletion py_configuration_files/enterprise_access.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@
DISCOVERY_URL = 'http://edx.devstack.discovery:18381'
ENTERPRISE_LEARNER_PORTAL_URL = 'http://localhost:8734'
ENTERPRISE_ADMIN_PORTAL_URL = 'http://localhost:1991'
ENTERPRISE_CATALOG_URL = 'http://edx.devstack.enterprise-catalog:18160'
ENTERPRISE_CATALOG_URL = 'http://enterprise.catalog.app:18160'
Copy link

Copilot AI Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hostname enterprise.catalog.app in the URL does not match the container name enterprise.catalog.app from docker-compose.yml, which uses hostname enterprise-catalog.devstack.edx (line 746). This mismatch will cause connection failures. The URL should use http://enterprise-catalog.devstack.edx:18160 to match the actual hostname, or the hostname in docker-compose.yml should be changed to enterprise.catalog.app.

Suggested change
ENTERPRISE_CATALOG_URL = 'http://enterprise.catalog.app:18160'
ENTERPRISE_CATALOG_URL = 'http://enterprise-catalog.devstack.edx:18160'

Copilot uses AI. Check for mistakes.
ENTERPRISE_SUBSIDY_URL = 'http://edx.devstack.enterprise-subsidy:18280'
ENTERPRISE_ACCESS_URL = 'http://localhost:18270'

Expand Down
2 changes: 1 addition & 1 deletion py_configuration_files/enterprise_subsidy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@
})

LMS_URL = 'http://edx.devstack.lms:18000'
ENTERPRISE_CATALOG_URL = 'http://edx.devstack.enterprise-catalog:18160'
ENTERPRISE_CATALOG_URL = 'http://enterprise.catalog.app:18160'
Copy link

Copilot AI Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hostname enterprise.catalog.app in the URL does not match the container name enterprise.catalog.app from docker-compose.yml, which uses hostname enterprise-catalog.devstack.edx (line 746). This mismatch will cause connection failures. The URL should use http://enterprise-catalog.devstack.edx:18160 to match the actual hostname, or the hostname in docker-compose.yml should be changed to enterprise.catalog.app.

Suggested change
ENTERPRISE_CATALOG_URL = 'http://enterprise.catalog.app:18160'
ENTERPRISE_CATALOG_URL = 'http://enterprise-catalog.devstack.edx:18160'

Copilot uses AI. Check for mistakes.
ENTERPRISE_SUBSIDY_URL = 'http://localhost:18280'
FRONTEND_APP_LEARNING_URL = 'http://localhost:' + LEARNING_MICROFRONTEND_PORT

Expand Down
2 changes: 1 addition & 1 deletion py_configuration_files/license_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@
# END CSRF CONFIG

ENTERPRISE_LEARNER_PORTAL_BASE_URL = 'http://localhost:8734'
ENTERPRISE_CATALOG_URL = 'http://edx.devstack.enterprise-catalog:18160'
ENTERPRISE_CATALOG_URL = 'http://enterprise.catalog.app:18160'
Copy link

Copilot AI Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hostname enterprise.catalog.app in the URL does not match the container name enterprise.catalog.app from docker-compose.yml, which uses hostname enterprise-catalog.devstack.edx (line 746). This mismatch will cause connection failures. The URL should use http://enterprise-catalog.devstack.edx:18160 to match the actual hostname, or the hostname in docker-compose.yml should be changed to enterprise.catalog.app.

Suggested change
ENTERPRISE_CATALOG_URL = 'http://enterprise.catalog.app:18160'
ENTERPRISE_CATALOG_URL = 'http://enterprise-catalog.devstack.edx:18160'

Copilot uses AI. Check for mistakes.
LMS_URL = 'http://edx.devstack.lms:18000'
SUPPORT_SITE_URL = 'https://support.edx.org'

Expand Down