Skip to content

Conversation

@vgulati-apphelix
Copy link
Member

@vgulati-apphelix vgulati-apphelix commented Oct 14, 2025

Description

This PR renames references from "arbi-bom" to "orbi-bom" as part of a chore task (BOMS-39). The change includes adding a success notification step to the Python requirements upgrade workflow.

  • Updates email recipient from arbi-bom to orbi-bom
  • Adds new success notification step to notify when the workflow completes successfully

Copilot AI review requested due to automatic review settings October 14, 2025 13:10
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR renames references from "arbi-bom" to "orbi-bom" as part of a chore task (BOMS-39). The change includes adding a success notification step to the Python requirements upgrade workflow.

  • Updates email recipient from arbi-bom to orbi-bom for consistency
  • Adds new success notification step to notify when the workflow completes successfully

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

subject: Upgrade python requirements workflow executed successfully in ${{github.repository}}
to: 'orbi-bom-upgrade-prs@2u-internal.jsmalerts.atlassian.net'
from: github-actions <github-actions@edx.org>
body: Upgrade python requirements workflow executed in ${{ github.repository }}. For details see "github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this was probably copy/pasted from elsewhere, but thought we could make the status more clear in the body as well.

Suggested change
body: Upgrade python requirements workflow executed in ${{ github.repository }}. For details see "github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}"
body: Upgrade python requirements workflow successfully executed in ${{ github.repository }}. For details see "github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robrap suggestion implemented.

Comment on lines 79 to 80
username: ${{secrets.edx_smtp_username}}
password: ${{secrets.edx_smtp_password}}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use consistent CAPS with the failure code?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: The other PR has all caps for some secrets, but not these, and maybe they should all move to ALL-CAPS?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robrap suggestion implemented.

Copilot AI review requested due to automatic review settings October 16, 2025 11:57
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@vgulati-apphelix vgulati-apphelix merged commit 85549a3 into master Oct 17, 2025
1 of 2 checks passed
@vgulati-apphelix vgulati-apphelix deleted the vgulati/boms-39_rename branch October 17, 2025 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants