Skip to content

feat: improve jsx-only-mode #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: improve jsx-only-mode #110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions lib/rules/no-literal-string.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,9 +97,16 @@ module.exports = {

function filterOutJSX(node) {
if (onlyValidateJSX) {
const isInsideJSX = context
.getAncestors()
.some(item => ['JSXElement', 'JSXFragment'].includes(item.type));
let isInsideJSX = false;
const ancestors = [...context.getAncestors()].reverse();
for (const ancestor of ancestors) {
if (ancestor.type === 'CallExpression') {
break;
} else if (['JSXElement', 'JSXFragment'].includes(ancestor.type)) {
isInsideJSX = true;
break;
}
}

if (!isInsideJSX) return true;

Expand Down
18 changes: 18 additions & 0 deletions tests/lib/rules/no-literal-string/jsx-only.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,26 @@ const cases = {
code: `<div>{[].map((a) => { switch (a) { case 'abc': return null; default: return null; } })}</div>`,
options: [{ mode: 'jsx-only' }],
},
{
code: `<div>{[].map((a) => { return <DIV foo={a} />; })}</div>`,
options: [{ mode: 'jsx-only' }],
},
{
code: `<div>{[].map((a) => { const x="some text"; console.log(x); return <DIV foo={a} />; })}</div>`,
options: [{ mode: 'jsx-only' }],
},
],
invalid: [
{
code: `<div>{[].map(() => { const x="some text"; console.log(x); return <DIV foo="bar">; })}</div>`,
options: [{ mode: 'jsx-only' }],
errors: 1,
},
{
code: `<div>{[].map(() => { const x="some text"; console.log(x); return <div>untranslated text</div> })}</div>`,
options: [{ mode: 'jsx-only' }],
errors: 1,
},
{
...testFile('invalid-jsx-only.jsx'),
options: [{ mode: 'jsx-only' }],
Expand Down