Conversation
zikajk
changed the title
…mmands, and rules
zikajk
force-pushed
the
replace-dynamic-strings-in-data
branch
from
0ff6453 to
888d2ac
Compare
ericdallo
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ${plugin:root} dynamic interpolation for plugin config, hooks, commands, and rules
For
commands/rules: their content never enters the config, so config-side can't see it.For plugin
hooks.json/.mcp.json/eca.json: they need to be interpolated while we still know which plugin they came from, so${plugin:root}and relative${file:...}resolve against the correct directory. By the time they're merged into the unified config, that context is gone.[6:11 PM]It might be a little bit redundant for eca.json, not sure how realistic that scenario is, but it doesn't hurt.