Fix locked vault bypass loopholes - #8
Conversation
- Fix Web app: Ensure locked notes are excluded from analytics word count and tag lists when the vault is locked. - Fix Android app: Prevent opening locked notes via intents (e.g. from widgets) if the vault is not unlocked. - Fix Android app: Prevent plaintext tags and image URLs from leaking to the local database when downloading a locked note from Firebase while the vault is locked.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Merged locally into main in commit aa1eaae with additional security hardening and biometric cleanup. |
Addresses multiple loopholes that allowed bypassing the locked folder security in both the web and Android apps.
Web app:
renderNavCountsandrenderAnalyticsViewto exclude locked notes when calculating tags and total word count if the vault is currently locked.Android app:
Intent.ACTION_VIEWhandler inMainActivity.ktto check theisLockedstate of the requested note and the vault's unlock status before navigating to the Edit Screen, preventing access via external intents.Note.ktfromFirestoreV2Mapto cleartagsandimageUrlswhen parsing an encrypted note without the decryption key, ensuring plaintext metadata doesn't leak into the local SQLite database.PR created automatically by Jules for task 12666639188099626001 started by @editinghero