Skip to content

Fix locked vault bypass loopholes - #8

Closed
editinghero wants to merge 1 commit into
mainfrom
fix-locked-vault-loopholes-12666639188099626001
Closed

Fix locked vault bypass loopholes#8
editinghero wants to merge 1 commit into
mainfrom
fix-locked-vault-loopholes-12666639188099626001

Conversation

@editinghero

Copy link
Copy Markdown
Owner

Addresses multiple loopholes that allowed bypassing the locked folder security in both the web and Android apps.

Web app:

  • Updates renderNavCounts and renderAnalyticsView to exclude locked notes when calculating tags and total word count if the vault is currently locked.

Android app:

  • Updates the Intent.ACTION_VIEW handler in MainActivity.kt to check the isLocked state of the requested note and the vault's unlock status before navigating to the Edit Screen, preventing access via external intents.
  • Updates Note.kt fromFirestoreV2Map to clear tags and imageUrls when parsing an encrypted note without the decryption key, ensuring plaintext metadata doesn't leak into the local SQLite database.

PR created automatically by Jules for task 12666639188099626001 started by @editinghero

- Fix Web app: Ensure locked notes are excluded from analytics word count and tag lists when the vault is locked.
- Fix Android app: Prevent opening locked notes via intents (e.g. from widgets) if the vault is not unlocked.
- Fix Android app: Prevent plaintext tags and image URLs from leaking to the local database when downloading a locked note from Firebase while the vault is locked.
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@editinghero

Copy link
Copy Markdown
Owner Author

Merged locally into main in commit aa1eaae with additional security hardening and biometric cleanup.

@editinghero editinghero closed this Sep 4, 2026
@editinghero
editinghero deleted the fix-locked-vault-loopholes-12666639188099626001 branch September 4, 2026 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant