Skip to content

Revoke Shared Web Links on Note Deletion - #7

Closed
editinghero wants to merge 1 commit into
mainfrom
fix-revoke-shares-on-note-deletion-17203876252443327662
Closed

Revoke Shared Web Links on Note Deletion#7
editinghero wants to merge 1 commit into
mainfrom
fix-revoke-shares-on-note-deletion-17203876252443327662

Conversation

@editinghero

Copy link
Copy Markdown
Owner

Added revokeSharesForNote method in WebShareManager to query and delete all share documents related to a specific note. Invoked this method in NoteRepository.kt during permanent deletion (permanentlyDelete) and trash clearing (clearTrash).


PR created automatically by Jules for task 17203876252443327662 started by @editinghero

Added logic to ensure that all shared web links associated with a note are deleted from Firestore when the note itself is permanently deleted or when the trash is cleared.
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@editinghero

Copy link
Copy Markdown
Owner Author

Merged locally into main in commit aa1eaae with additional security hardening and biometric cleanup.

@editinghero editinghero closed this Sep 4, 2026
@editinghero
editinghero deleted the fix-revoke-shares-on-note-deletion-17203876252443327662 branch September 4, 2026 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant