Fix lag by caching derived encryption key in AuthManager - #11
Conversation
The encryption key derived using PBKDF2WithHmacSHA256 took ~300ms to compute. During cloud sync, `getEncryptionKey()` was called repeatedly inside a loop for each locked note (in `uploadNotesBatch` and `fetchCloudNotes`). This blocked the thread significantly and caused severe app lag. This commit introduces a memory cache for the derived `SecretKey` in `AuthManager`, keyed by the user's ID (`uid`). The cache avoids recomputing the key on every note sync, massively speeding up the sync process. The cache is securely cleared upon sign out (`signOut()`).
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Merged locally into main in commit aa1eaae with additional security hardening and biometric cleanup. |
1 participant
Fixes the performance lag during syncing caused by repeated PBKDF2 key derivations in AuthManager. The derived key is now cached by uid and cleared on sign-out.
PR created automatically by Jules for task 5461355783730067083 started by @editinghero