Fix vault notes decryption and loading on unlock - #10
Conversation
- `AuthManager.getEncryptionKey()` now retrieves the active vault key directly from `VaultSecurityManager`. - The `observeFirestoreNotes()` flow now reacts to vault unlock events, forcing a re-fetch and re-decryption of notes. - Gracefully handles backward compatibility by adding `isDecryptionFailed` field in `Note.kt` and utilizing a fallback `try-catch` block. - Injected `VaultSecurityManager` to `AuthManager` in `NotesViewModel` to support retrieving the centralized key.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Merged locally into main in commit aa1eaae with additional security hardening and biometric cleanup. |
1 participant
Fixes an issue where vault notes wouldn't correctly display their content once unlocked. This occurred because
AuthManagerhad its own separate key-derivation logic that didn't match the in-memory master key, and its Firestore listener didn't react to vault unlock events.PR created automatically by Jules for task 10082531411857117352 started by @editinghero