Windows offline installer#6
Open
eoinjordan wants to merge 6 commits intomasterfrom
Open
Conversation
Author
|
Installer x86 functionally tested on Windows VM: 
|
Chocolatey ImageMagick on Windows runners lacks PNG codec delegates, causing prepare-branding.ps1 to fail with: magick.exe: no decode delegate for this image format Fix: generate header.bmp (150x57) and welcome.bmp (164x314) on macOS using Homebrew ImageMagick from img/linux-collection.png, commit them to the repo, and remove the Install ImageMagick and Generate installer branding assets CI steps entirely. BMPs will be regenerated locally when the source image changes.
…ect graph image The previous header.bmp and welcome.bmp were generated from img/linux-collection.png which is a raw sensor data graph screenshot, not the Edge Impulse brand logo. Regenerate from studio/public/themes/default/png/logo.png (same source as the serial-daemon installer). Also update prepare-branding.ps1 to look for img/edge-impulse-logo.png first, falling back to the monorepo logo path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces official support for a Windows offline installer for the Edge Impulse Linux CLI, targeting environments where
npm installis not feasible. It adds a complete GitHub Actions workflow to build and package the CLI as a native Windows installer, along with all necessary scripts and documentation for usage and distribution. The installer bundles Node.js, all dependencies, and CLI shims, and modifies the Windows PATH during installation and uninstallation.The most important changes are:
Windows Offline Installer Infrastructure:
.github/workflows/build-windows-installer.yml) to build Windows installers for bothx64andarm64architectures, including artifact and release upload steps.windows-installer/stage.ps1) to automate gathering build artifacts, dependencies, and Node.js into a staging directory for packaging.windows-installer/installer.nsi) to create a Windows installer that sets up the CLI, Node.js runtime, dependencies, and manages PATH modifications and uninstallation..gitignorein the installer directory to exclude build and staging output.Documentation:
README.mdto document the new Windows offline installer, including its contents, requirements, limitations, and instructions for building or downloading artifacts from GitHub Actions.