Conversation
azenla
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in #47 we need some unit tests for basic build correctness checks outside of UEFI target contexts.
This is a bit tricky for Sprout specifically, because it uses UEFI libs which only support building binaries against
x86_64-unknown-uefi/aarch64-unknown-uefi- which means test binariescargo testproduces won't run in most normal non-UEFI contexts.We can fix that by separating testable code with no hard UEFI dependencies into standalone crates, and testing those.
This introduces
crates/bls- agnostic BLS-related code without UEFI deps.crates/parsing- agnostic parsing code without UEFI deps.