Change board's ready trigger / Ensure attachment of servos#40
Open
sevastos wants to merge 3 commits intoecto:masterfrom
Open
Change board's ready trigger / Ensure attachment of servos#40sevastos wants to merge 3 commits intoecto:masterfrom
sevastos wants to merge 3 commits intoecto:masterfrom
Conversation
|
Something's wrong here, this breaks the device: 'ACM' functionality in lib.board.js that was added here: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for your work ecto, duino is really cool and easy to get into, good job!
Anyway, this PR fixes #21.
It was a sort of racing condition where the board would sometimes trigger the
readyevent earlier and it should, now it listens for serialport'sopenevent.Also I made it so that you can use servos inside the board's
readyevent callback.Lastly updated the board's name property to
pathbased on serialport's.Cheers