[depre] Deprecate Symplify set, as mostly part of common set that have more clearer naming + remove deprecate phpunit and strict sets#31
Merged
Conversation
…e more clearer naming
…rrow rules in config/set/sympify.php
1dace7f to
d3c370b
Compare
d3c370b to
0e12662
Compare
9b6a6b9 to
0e12662
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Deprecate the
symplifyprepared set and remove the already-deprecatedphpunitandstrictsets.symplify— soft-deprecated. Its rules were duplicates of thecommonsets under less clear names. The rules now live incommon(array, docblock, spaces). Passingsymplify: truenow triggers anE_USER_DEPRECATEDwarning and no longer loads the set.phpunit— removed. It was dangerous to run without proper context. Use Rector instead.strict— removed. Same reason — dangerous without context. Use Rector instead.SetList::PHPUNITandSetList::STRICTconstants removed;SetList::SYMPLIFYmarked@deprecated.packages/coding-standard/config/symplify.php; narrowedconfig/set/symplify.php.How to update your
ecs.phpDrop the deprecated flags. The annotation/spacing/strict-types rules they covered are now in the
commonsets — enablecommon: true(or the matchingwith*Level()methods).use Symplify\EasyCodingStandard\Config\ECSConfig; return ECSConfig::configure() ->withPreparedSets( common: true, - symplify: true, - phpunit: true, - strict: true, ) ->withRules([ // ... ]);If you still need strict-types or PHPUnit-specific transforms, move them to Rector where they run with proper context.