Open
Conversation
Owner
|
I'm looking through your changes and will be able to accept a few of them. I'm not done yet, but all 3 of your bullet points are items I think are good suggestions. I did notice 2 problematic changes that you made though in other files:
I'll follow up with more and accept some cherry-picked commits from your pull request shortly. By the way, thanks for actively helping out and coding some of the features yourself. Don't get me wrong, everyone who simply suggests/asks for features here helps me out a great deal, but including working code with the feature is ideal -- it's definitely how we'll all get this viewer to a state that exceeds the official one! |
|
would love to see the InfoWindow added :-) |
bryankaraffa
pushed a commit
to bryankaraffa/torque
that referenced
this pull request
Jul 30, 2017
bugfixed pid_commit.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cdnjs.cloudflare.com