fix: use textContent instead of innerHTML to clear elements - #1167
Open
oioki wants to merge 1 commit into
Open
Conversation
Assigning to innerHTML is a Trusted Types injection sink, rejected even when the value is an empty string. textContent = '' clears children identically and is not a sink.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assigning to
innerHTMLis a Trusted Types injection sink. On a page sendingrequire-trusted-types-for 'script', the browser rejects the assignment even when the value is an empty string — so zrender throws indispose(), and on clip-path and gradient updates.textContent = ''clears children identically and is not a sink.svg/Painter.ts#clear()assignednull, relying on[LegacyNullToEmptyString]; it now assigns''.