fix(text): use contentHeight for outerHeight to fix vertical alignment - #1166
Open
waterWang wants to merge 1 commit into
Open
fix(text): use contentHeight for outerHeight to fix vertical alignment#1166waterWang wants to merge 1 commit into
waterWang wants to merge 1 commit into
Conversation
…tical alignment When style.height is set (e.g. by Treemap beforeUpdate for truncation), outerHeight was incorrectly set to style.height instead of the actual rendered text height (contentHeight). This caused treemap labels in small blocks to be vertically misaligned. Fix: - In parseText: use contentHeight for outerHeight instead of height. - In parseRichText: separate outerHeight from height. outerHeight = calculatedHeight (actual rendered text height), height = retrieve2(). style.height should only serve as the truncation boundary; outerHeight is used for vertical alignment placement (adjustTextY in Text.ts).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
In , was being set from (via the / variable). When is explicitly set — as Treemap does in its to establish a truncation boundary — incorrectly reflects the full block height rather than the actual rendered text height. Since is what uses for vertical alignment (), treemap labels in small blocks appeared vertically misaligned (text positioned as if its bounding box were the whole block).
Fix
continues to serve only as the truncation boundary; is used purely for placement.
Why
Fixes apache/echarts#21673 — Treemap label vertical alignment broken when is set by with .
Tests
All 68 existing zrender unit tests pass, including . Typecheck passes (only pre-existing unrelated error in ).