Skip to content

use Gradlew#467

Open
milyin wants to merge 3 commits intomainfrom
gradlew
Open

use Gradlew#467
milyin wants to merge 3 commits intomainfrom
gradlew

Conversation

@milyin
Copy link
Copy Markdown
Contributor

@milyin milyin commented Apr 18, 2026

Fixes #312

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds the Gradle Wrapper to the repository and switches CI/documentation toward using ./gradlew so builds use a pinned, reproducible Gradle version (fixes #312).

Changes:

  • Add Gradle Wrapper scripts and wrapper artifacts (gradlew, gradlew.bat, gradle/wrapper/*) pinned to Gradle 8.12.1 with SHA-256 verification.
  • Update GitHub Actions workflows to stop installing a system Gradle/version and instead run tasks via ./gradlew.
  • Update README to document that the repository ships the Gradle Wrapper.

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
gradlew Adds the POSIX Gradle Wrapper startup script.
gradlew.bat Adds the Windows Gradle Wrapper startup script.
gradle/wrapper/gradle-wrapper.properties Pins Gradle distribution URL and checksum for wrapper.
gradle/wrapper/gradle-wrapper.jar Adds the wrapper runtime JAR required by gradlew.
README.md Documents wrapper usage and removes “install Gradle” requirement.
.github/workflows/ci.yml Switches test execution from gradle to ./gradlew and removes explicit gradle-version.
.github/workflows/publish-dokka.yml Uses ./gradlew dokkaGenerate and removes wrapper-generation steps.
.github/workflows/publish-jvm.yml Removes explicit Gradle version and wrapper-generation steps (relies on checked-in wrapper).
.github/workflows/publish-android.yml Removes explicit Gradle version and wrapper-generation steps (relies on checked-in wrapper).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread README.md Outdated
Copy link
Copy Markdown

Copilot AI commented Apr 18, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • dl.google.com
    • Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED --add-opens=java.xml/javax.xml.namespace=ALL-UNNAMED -XX:MaxMetaspaceSize=384m -XX:+HeapDumpOnOutOfMemoryError -Xms256m -Xmx512m -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

@milyin milyin requested a review from yellowhatter April 18, 2026 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use Gradlew in the build system instead of Gradle

3 participants