Conversation
There was a problem hiding this comment.
Pull request overview
Adds the Gradle Wrapper to the repository and switches CI/documentation toward using ./gradlew so builds use a pinned, reproducible Gradle version (fixes #312).
Changes:
- Add Gradle Wrapper scripts and wrapper artifacts (
gradlew,gradlew.bat,gradle/wrapper/*) pinned to Gradle 8.12.1 with SHA-256 verification. - Update GitHub Actions workflows to stop installing a system Gradle/version and instead run tasks via
./gradlew. - Update README to document that the repository ships the Gradle Wrapper.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
gradlew |
Adds the POSIX Gradle Wrapper startup script. |
gradlew.bat |
Adds the Windows Gradle Wrapper startup script. |
gradle/wrapper/gradle-wrapper.properties |
Pins Gradle distribution URL and checksum for wrapper. |
gradle/wrapper/gradle-wrapper.jar |
Adds the wrapper runtime JAR required by gradlew. |
README.md |
Documents wrapper usage and removes “install Gradle” requirement. |
.github/workflows/ci.yml |
Switches test execution from gradle to ./gradlew and removes explicit gradle-version. |
.github/workflows/publish-dokka.yml |
Uses ./gradlew dokkaGenerate and removes wrapper-generation steps. |
.github/workflows/publish-jvm.yml |
Removes explicit Gradle version and wrapper-generation steps (relies on checked-in wrapper). |
.github/workflows/publish-android.yml |
Removes explicit Gradle version and wrapper-generation steps (relies on checked-in wrapper). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Agent-Logs-Url: https://github.com/eclipse-zenoh/zenoh-java/sessions/8a1e11ab-5586-45f6-93c6-d6225c551eb5 Co-authored-by: milyin <1909657+milyin@users.noreply.github.com>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #312