Skip to content

Report AsyncFile handler failures to context - #6300

Draft
Boulea7 wants to merge 1 commit into
eclipse-vertx:masterfrom
Boulea7:fix-5343-async-file-handler-failures
Draft

Report AsyncFile handler failures to context#6300
Boulea7 wants to merge 1 commit into
eclipse-vertx:masterfrom
Boulea7:fix-5343-async-file-handler-failures

Conversation

@Boulea7

@Boulea7 Boulea7 commented Aug 10, 2026

Copy link
Copy Markdown

Motivation:

Fixes #5343.

Exceptions thrown by AsyncFile data or end handlers should be reported to the owning Context, matching existing Vert.x handler semantics and the maintainer guidance in the issue.

This change installs a context exception handler on the AsyncFile inbound buffer and adds regression coverage for both handler types.

Testing:

  • mvn -pl vertx-core -Dtest=FileSystemTest#testAsyncFileHandlerFailuresAreReportedToContext test -B — 1 passed
  • mvn -pl vertx-core -Dtest=FileSystemTest,InboundBufferTest test -B — 141 passed
  • mvn -pl vertx-core -DskipTests verify -Pcheckstyle -B — passed; Spotless reported 0 files needing changes
  • git diff --check origin/master...HEAD — passed

Before this split, an earlier broad local run was not fully green. It encountered two unrelated environment-sensitive failures outside the modified paths:

  • NameResolverTest#testRotationalServerSelection: expected 127.0.0.4 but observed 127.0.0.3.
  • Http1xTest#requestAbsNoPort: connection timeout to www.google.com:80.

These are not counted as passing tests. All 142 relevant test executions listed above passed on the current rebased commit.

Conformance:

AI assistance: OpenAI Codex assisted with implementation and testing.

@vietj

vietj commented Aug 11, 2026

Copy link
Copy Markdown
Member

can you make two contributions instead of one that makes 2 changes ?

@Boulea7

Boulea7 commented Aug 11, 2026

Copy link
Copy Markdown
Author

Thanks, I'll split these into two separate contributions.

@Boulea7
Boulea7 marked this pull request as draft August 11, 2026 08:41
@Boulea7
Boulea7 force-pushed the fix-5343-async-file-handler-failures branch from 0fac57e to eee248e Compare August 11, 2026 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

exceptionHandler of AsyncFile is not triggered

2 participants