feat(core): add semantic composed thing#1174
feat(core): add semantic composed thing#1174danielpeintner wants to merge 1 commit intoeclipse-thingweb:masterfrom
Conversation
based on the work started in eclipse-thingweb/node-wot@master...semantic-layer
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1174 +/- ##
=======================================
Coverage 76.52% 76.52%
=======================================
Files 80 80
Lines 16705 16705
Branches 1616 1616
=======================================
Hits 12784 12784
Misses 3891 3891
Partials 30 30 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Some early feedback without looking at the code. My gut feeling is that this should be an extension to node-wot. Sort of a richer framework that we can build on top of the raw API. I believe that node-wot should stay as close as possible to the Thing Description interaction model abstraction. Anyhow I think the extension is a great idea, but I'd like to see it as a standalone project that uses node-wot rather than another package inside this project. |
This is good feedback and my response to it is as follows. |
From some discussions in the TD/Binding TF at WoT WG, I remember others (@mjkoster if I am not wrong) having interest in this so it can indeed be standardized. |
Based on the work started in https://github.com/eclipse-thingweb/node-wot/tree/semantic-layer I would like to continue working on providing a
SemanticComposedThingas a wrapper aroundConsumedThing.The idea is that consumers no longer need to know the property
nameto get the data they want. Instead it should be possible to use@type(e.g., read property with"@type": "iot:BinarySwitchData")Some thoughts:
Note: at the moment the PR is still in draft state since there are many open questions (see code) especially if we want to properly define input/output data. Comments are welcome!