Storage restart#278
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the binary persistence roots handler to support “storage restart” scenarios where an existing PersistenceRoots.Default instance can be re-loaded after its rootIdMapping was discarded during the prior load cycle.
Changes:
- Rebuilds the
identifier → objectIdroot mapping from the binary payload whenPersistenceRoots.Default.$rootIdMapping()isnullduringupdateState(). - Adds inline documentation explaining why the mapping may be
nullon re-load and why rebuilding is required.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fh-ms
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Serializer part of storage restart feature.
This feature enables the storage to start an embedded storage after it has been shut down.