Add a generic timebase handler to TimeDaemon by florianfueller · Pull Request #244 · eclipse-score/time

florianfueller · 2026-10-09T15:26:59Z

Move common setup, messaging, and lifecycle code out of SvtHandler
Allow TimeDaemon to run multiple handlers through a custom factory
Expose public Bazel targets for custom handlers

closes #265

github-actions · 2026-10-09T15:29:02Z

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //:license-check

Status: ⚠️ Needs Review

Click to expand output

[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.6.0) and connecting to it...
INFO: Invocation ID: c339247d-aeca-4b5b-89ca-d617e0dc6bae
Computing main repo mapping: 
Computing main repo mapping: 
WARNING: For repository 'platforms', the root module requires module version platforms@1.0.0, but got platforms@1.1.0 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'score_platform', the root module requires module version score_platform@0.7.1, but got score_platform@0.7.2 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'rules_oci', the root module requires module version rules_oci@2.2.7, but got rules_oci@2.3.0 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'score_devcontainer', the root module requires module version score_devcontainer@1.8.0, but got score_devcontainer@1.11.1 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 3 packages loaded
WARNING: Target pattern parsing failed.
ERROR: Skipping '//:license-check': no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/time/time/BUILD
ERROR: no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/time/time/BUILD
INFO: Elapsed time: 18.941s
INFO: 0 processes.
ERROR: Build did NOT complete successfully
ERROR: Build failed. Not running target

github-actions · 2026-10-09T15:36:40Z

Quality pack traceability report for this pull request:

Status: PASS (workflow run)

Traceability gate input: /home/runner/work/time/time/_build/metrics.json
------------------------------------------------------------------------
[comp_req]
  Requirements with source links: 9/58 (15.52%)
  Requirements with test links:   5/58 (8.62%)
  Requirements fully linked:      5/58 (8.62%)
  Tests linked to requirements:   8/456 (1.75%)
  Broken test references:         0
------------------------------------------------------------------------
Threshold check passed.

github-actions · 2026-10-09T15:37:06Z

Documentation preview for this pull request is available at:
pr-244: https://eclipse-score.github.io/time/pr-244/

- Move common setup, messaging, and lifecycle code out of SvtHandler - Allow TimeDaemon to run multiple handlers through a custom factory - Expose public Bazel targets for custom handlers Refs eclipse-score#265 Signed-off-by: Florian Füller <5454068+florianfueller@users.noreply.github.com>

lavrovvalera · 2026-10-28T13:43:45Z

+    /// A timeout makes the handler fail.
+    /// \return The machine passed to Add().
+    template <typename M>
+    std::shared_ptr<M> Add(std::shared_ptr<M> machine, std::chrono::seconds init_timeout = std::chrono::seconds{20});


I'm not sure it is a good approach to have the default value here.
would beleave it might be forbidden by misra even

lavrovvalera · 2026-10-28T13:46:34Z

@@ -0,0 +1,103 @@
+/********************************************************************************


is it the timebase_handler_factory_test.*?

lavrovvalera · 2026-10-28T13:52:12Z

+/// The JobRunner initializes the machines on a worker thread. Once all machines are ready, proactive machines
+/// start in Add() order and stop in reverse order. Add machines that must run first before their data sources.
+///
+/// 	param T Type of messages sent through the MessageBroker.


Suggested change

/// param T Type of messages sent through the MessageBroker.

/// param T Type of messages sent through the MessageBroker.

lavrovvalera · 2026-10-28T13:53:06Z

+    /// Keeps the machines alive. The MessageBroker holds only weak references.
+    std::vector<std::shared_ptr<BaseMachine>> machines_;
+    std::vector<std::shared_ptr<ProactiveMachine>> start_order_;  // in Add() order
+    std::string name_;


shall it be const?

lavrovvalera · 2026-10-28T13:53:42Z

+    bool is_initialized_;
+};
+
+template <typename T>


Suggested change

template <typename T>

template <typename T, typename M>

lavrovvalera · 2026-10-28T14:44:02Z

+)
+
+alias(
+    name = "generic_timebase_handler",


shall all these be combined to time_daemon_core?
or, if you ant to split the time daemon, then

core

main

time_handlers

lavrovvalera · 2026-10-28T14:45:51Z

+    actual = "//score/time_daemon/src/msg_broker",
+    visibility = ["//visibility:public"],
+)
+


I would also somehow encrease the readability here
group the aliases with

the core types and targets, whcih provide the possibility to add any new timebase

the svt -related targets

the tiem daemon bricks

lavrovvalera · 2026-10-28T14:48:03Z


   config/configuration_guide

+Choosing Handlers


is it really a choosing?

lavrovvalera · 2026-10-28T14:48:35Z

+Handler Lifecycle
+=================
+
+``TimeDaemon`` owns the handlers. ``Initialize()`` fails if the list is empty or any handler is null.


shall we describe here a small state machine or it wil be too much?

lavrovvalera · 2026-10-28T14:50:20Z


-During initialization, the ``Application`` uses a factory pattern to create components in specific order:
+``TimeDaemon`` owns the handlers. Its default constructor calls ``CreateTimebaseHandlers()``.
+Exactly one linked factory must define this function (see :ref:`time_daemon_user_manual`).


I would find that a bit starange, that the detailed design, which is (or should be) way more deatialed and tehcnically filled refernce here the user manual ..

github-project-automation Bot added this to TIM - Time FT Oct 9, 2026

github-project-automation Bot moved this to In Progress in TIM - Time FT Oct 9, 2026

florianfueller had a problem deploying to workflow-approval October 9, 2026 15:27 — with GitHub Actions Error

florianfueller force-pushed the feature/generic_timebase_handler branch from 665e84a to bca6aef Compare October 12, 2026 07:45

florianfueller had a problem deploying to workflow-approval October 12, 2026 07:45 — with GitHub Actions Error

florianfueller force-pushed the feature/generic_timebase_handler branch from bca6aef to 421c457 Compare October 12, 2026 08:11

florianfueller had a problem deploying to workflow-approval October 12, 2026 08:11 — with GitHub Actions Error

florianfueller had a problem deploying to workflow-approval October 16, 2026 13:34 — with GitHub Actions Error

florianfueller had a problem deploying to workflow-approval October 16, 2026 18:41 — with GitHub Actions Error

florianfueller force-pushed the feature/generic_timebase_handler branch from 6242ad5 to b23ca0b Compare October 16, 2026 18:45

florianfueller had a problem deploying to workflow-approval October 16, 2026 18:45 — with GitHub Actions Error

florianfueller force-pushed the feature/generic_timebase_handler branch from b23ca0b to f7e2a49 Compare October 16, 2026 19:00

florianfueller had a problem deploying to workflow-approval October 16, 2026 19:01 — with GitHub Actions Error

florianfueller force-pushed the feature/generic_timebase_handler branch from f7e2a49 to 1f74064 Compare October 16, 2026 19:12

florianfueller had a problem deploying to workflow-approval October 16, 2026 19:13 — with GitHub Actions Error

florianfueller force-pushed the feature/generic_timebase_handler branch from 1f74064 to e2316e4 Compare October 16, 2026 19:19

florianfueller had a problem deploying to workflow-approval October 16, 2026 19:19 — with GitHub Actions Error

florianfueller force-pushed the feature/generic_timebase_handler branch from e2316e4 to d4330e3 Compare October 16, 2026 19:53

florianfueller had a problem deploying to workflow-approval October 19, 2026 09:42 — with GitHub Actions Error

florianfueller had a problem deploying to workflow-approval October 19, 2026 13:01 — with GitHub Actions Error

florianfueller force-pushed the feature/generic_timebase_handler branch from ef85ca2 to f086710 Compare October 20, 2026 06:38

florianfueller had a problem deploying to workflow-approval October 20, 2026 06:38 — with GitHub Actions Error

florianfueller force-pushed the feature/generic_timebase_handler branch from f086710 to 7378db6 Compare October 20, 2026 06:59

florianfueller had a problem deploying to workflow-approval October 20, 2026 06:59 — with GitHub Actions Error

florianfueller force-pushed the feature/generic_timebase_handler branch from 7378db6 to 6229b80 Compare October 20, 2026 07:19

florianfueller had a problem deploying to workflow-approval October 20, 2026 07:19 — with GitHub Actions Error

florianfueller force-pushed the feature/generic_timebase_handler branch from 6229b80 to c71e31b Compare October 20, 2026 07:28

florianfueller had a problem deploying to workflow-approval October 20, 2026 07:28 — with GitHub Actions Error

florianfueller force-pushed the feature/generic_timebase_handler branch from c71e31b to 2fc7c4d Compare October 20, 2026 07:41

florianfueller had a problem deploying to workflow-approval October 20, 2026 07:41 — with GitHub Actions Error

florianfueller force-pushed the feature/generic_timebase_handler branch from 2fc7c4d to 788e7e6 Compare October 20, 2026 07:47

florianfueller had a problem deploying to workflow-approval October 20, 2026 07:47 — with GitHub Actions Error

florianfueller changed the title ~~Generic Timebase Handler~~ Add a generic timebase handler to TimeDaemon Oct 20, 2026

florianfueller force-pushed the feature/generic_timebase_handler branch from 788e7e6 to fd9e47c Compare October 22, 2026 10:59

florianfueller had a problem deploying to workflow-approval October 22, 2026 10:59 — with GitHub Actions Error

lavrovvalera suggested changes Oct 28, 2026

View reviewed changes

Addressing review comments - 01

e081848

florianfueller requested a deployment to workflow-approval October 29, 2026 13:31 — with GitHub Actions Waiting

		@@ -0,0 +1,103 @@
		/********************************************************************************

	/// param T Type of messages sent through the MessageBroker.
	/// param T Type of messages sent through the MessageBroker.

Conversation

florianfueller commented Oct 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

License Check Results

Uh oh!

github-actions Bot commented Oct 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 9, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This branch is waiting to be deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

florianfueller commented Oct 9, 2026 •

edited

Loading

github-actions Bot commented Oct 9, 2026 •

edited

Loading

github-actions Bot commented Oct 9, 2026 •

edited

Loading