Repository navigation
Bump score_lifecycle pin and fix simple_lifecycle mw::com config - #350
Open
hskang-amelia wants to merge 4 commits into
Open
hskang-amelia wants to merge 4 commits into
hskang-amelia wants to merge 4 commits into
Conversation
hskang-amelia
requested review from
AlexanderLanin,
FScholPer,
MaximilianSoerenPollak,
PiotrKorkus,
antonkri,
dcalavrezo-qorix,
lurtz,
nradakovic,
opajonk and
pawelrutkaq
as code owners
September 21, 2026 04:03
hskang-amelia
force-pushed
the
bump-lifecycle-pin-fix-simple-lifecycle-mw-com
branch
3 times, most recently
from
September 21, 2026 07:25
bd23510 to
0876214
Compare
|
The created documentation from the pull request is available at: docu-html |
Contributor
|
Hi @hskang-amelia , sorry I was not aware of this PR otherwise I had reviewed it earlier. |
Bumps score_lifecycle to lifecycle main (7bed0de1, #857) and packages mw_com_config.json into the simple_lifecycle showcase so mw::com initializes correctly for components run by launch_manager. The config is staged both under etc/ (for launch_manager's own cwd) and bin/etc/ (for components chdir'd into bin_dir by ProcessGroupManager), since mw::com resolves the config path relative to each component's cwd at exec time. Lifecycle patches: drop 001 (baselibs Rust target migration is upstream), regenerate 002 against the new MODULE.bazel, and add 003 to drop the lifecycle "glossary" toctree entry. Since lifecycle #761 the glossary lives in score_platform and is only mounted when lifecycle is the root module, so the entry dangles here. Also point the lifecycle verification report link at module_verification_report, renamed in lifecycle #703.
Launch Manager now chdirs each component into deployment_config.working_dir, which defaults to /tmp. control_daemon therefore could not find ./etc/mw_com_config.json or ./etc/logging.json, aborted (exit 134) and was restarted in a loop, while the platform integration test still passed. Point working_dir at /showcases/data/simple_lifecycle, where the bundle already places etc/, and drop the bin/etc copy of mw_com_config.json that never reached the image.
The showcase CLI exits 0 even while Launch Manager keeps restarting a crashing app, so the PIT passed during the control_daemon crash loop. Fail on 'unexpected termination' and require the Startup and fallback_run_target transitions and a clean LM exit. Verified the test now fails with working_dir removed.
Lifecycle main links feature requirements that only exist in newer score_platform. Move the docs stack together so the docs build is clean again: - score_platform 6d65a262 -> v0.7.4 (32759e0a). Drop the patch that removed its lifecycle glossary; lifecycle no longer ships one. - score_persistency 961c0a09 -> main (2bfa2f1d), which follows the renamed persistency requirements. Regenerate patch 003. - score_process_description 98d1d5f4 -> v2.2.2 (0e01b2cc), needed by platform v0.7.4 links. - score_docs_as_code f1b30375 -> v8.6.0 (d9a43b1a), matching process v2.2.2. Still has score_devcontainer as a dev dependency (eclipse-score#400).
hskang-amelia
force-pushed
the
bump-lifecycle-pin-fix-simple-lifecycle-mw-com
branch
from
October 29, 2026 05:44
0ff4de8 to
7b7910e
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
score_lifecyclefrom85da2168(2026-09-08) to lifecycle main7bed0de1(#857, 2026-10-28).This pulls in the new control API (
ILmControl, #489) and the_msconfig field names (#637).001-migrate-baselibs-rust-targets.patch: upstream no longer uses the removed@score_baselibs//srcaliases.002-undev-integration-test-deps.patchfor the newMODULE.bazellayout (same two-line change).003-drop-glossary-toctree-entry.patch. Since lifecycle #761 the lifecycle glossary lives inscore_platformand lifecycle only mounts it when it is the root module, so itsglossarytoctree entry dangles here. The terms still resolve through the platform glossary.score_platform:score_platform6d65a262→ v0.7.4 (32759e0a); drop001-remove-duplicate-lifecycle-glossary.patch, lifecycle no longer ships its own glossary.score_persistency961c0a09→ main (2bfa2f1d), which follows the renamed persistency requirements; regenerate003-undev-deps-for-root-module.patch(same set of deps).score_process_description98d1d5f4→ v2.2.2 (0e01b2cc), needed by platform v0.7.4.score_docs_as_codef1b30375→ v8.6.0 (d9a43b1a), matching process v2.2.2. It still hasscore_devcontaineras a dev dependency (fix(deps): pin docs-as-code to the corrected revision #400).MODULE.bazel.lockupdated accordingly.simple_lifecycleshowcase actually run.launch_manager_config.jsonto the_msfield names.mw_com_config.json(LmControlService, service id7101) underetc/.deployment_config.working_dirto/showcases/data/simple_lifecycle. Launch Manager nowchdirs each component intoworking_dir(default/tmp), socontrol_daemoncould not find./etc/mw_com_config.json/./etc/logging.json.unexpected terminationand requires the Startup andfallback_run_targettransitions and a clean LM exit.run_showcasesreturns the CLI output so tests can do this.module_verification_report(renamed in lifecycle #703).Why
With the old pin, and also with only the pin bumped,
control_daemonaborts (exit 134) on a missing mw::com config and Launch Manager restarts it in a loop.//platform_integration_tests/lifecyclestill passes in that state, because it only checked that the showcase runs. The new assertions catch this: withworking_dirremoved, the lifecycle PIT fails.Testing
bazel run --lockfile_mode=error //:docs_shim: build succeeded, 0 warnings (lifecycle main alone gave 302 warnings against the old docs stack).59f6e530inghcr.io/eclipse-score/devcontainer:v1.11.0(PIT + ITF 6/6, lifecycle PIT log with nounexpected termination).