-
Notifications
You must be signed in to change notification settings - Fork 35
Add resolved-dependency override mechanism for DR-008 #278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Subramanian-K812
wants to merge
7
commits into
eclipse-score:main
Choose a base branch
from
qorix-group:Subramanian-K812_resolve_override_mechanism
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+856
−0
Draft
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
b1b599b
feat: add DR-008 resolved-dependency resolve + override mechanism
Subramanian-K812 24c6ea1
fix: remove bazel_config, always overwrite overrides, clean injection…
Subramanian-K812 eba7338
fix: revert update_module_from_known_good.py, move generate_override_…
Subramanian-K812 7b5a036
fix: ruff format fix for scripts/tooling/BUILD
Subramanian-K812 5aa419d
fix: revert out-of-scope changes to module.py, update_module_from_kno…
Subramanian-K812 ff6e330
feat: warn on unresolved declared deps, add bazel test target for kno…
Subramanian-K812 cff77c1
fix: overwrite() replaces a module's own override instead of duplicat…
Subramanian-K812 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| # ******************************************************************************* | ||
| # Copyright (c) 2026 Contributors to the Eclipse Foundation | ||
| # | ||
| # See the NOTICE file(s) distributed with this work for additional | ||
| # information regarding copyright ownership. | ||
| # | ||
| # This program and the accompanying materials are made available under the | ||
| # terms of the Apache License Version 2.0 which is available at | ||
| # https://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # ******************************************************************************* | ||
| load("@rules_python//python:defs.bzl", "py_binary", "py_library") | ||
| load("@score_tooling//python_basics:defs.bzl", "score_py_pytest") | ||
|
|
||
| # Library target: the known_good package (models + generators). | ||
| # Used as a dep by //scripts/tooling and by the resolve_deps binary below. | ||
| py_library( | ||
| name = "known_good", | ||
| srcs = glob( | ||
| ["**/*.py"], | ||
| exclude = ["tests/**"], | ||
| ), | ||
| visibility = ["//visibility:public"], | ||
| ) | ||
|
|
||
| # Tests for the known_good package (currently: ResolvedDependencies). | ||
| # Not part of //scripts/tooling:tooling_tests, whose glob is scoped to scripts/tooling/tests/. | ||
| score_py_pytest( | ||
| name = "known_good_tests", | ||
| srcs = glob(["tests/**/*.py"]), | ||
| data = ["//:known_good.json"], | ||
| pytest_config = "//:pyproject.toml", | ||
| deps = [":known_good"], | ||
| ) | ||
|
|
||
| # Runnable binary for the resolve + inject workflow. | ||
| # Stage 1 (export): bazel run //scripts/known_good:resolve_deps -- \ | ||
| # --mod-graph graph.json --export artifacts/resolved_versions.json | ||
| # Stage 2 (inject): bazel run //scripts/known_good:resolve_deps -- \ | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please keep Stage 1 and Stage 2 in sync. |
||
| # _module/MODULE.bazel --resolved-deps _resolved_deps/ | ||
| py_binary( | ||
| name = "resolve_deps", | ||
| srcs = ["resolved_dependencies.py"], | ||
| main = "resolved_dependencies.py", | ||
| visibility = ["//visibility:public"], | ||
| deps = [":known_good"], | ||
| ) | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please extend description for Stage 1.
bazel mod graph --output json > graph.jsonis required as prerequisite.In the script please make use of
BUILD_WORKING_DIRECTORYorBUILD_WORKSPACE_DIRECTORYenvironment variable so the graph.json file can be found without requiring to be indata = ["..."]