Skip to content

Dynamic config and file_transfer impl migration - #246

Merged
rmaddikery merged 2 commits into
eclipse-score:mainfrom
Y-Vaishnavi:5A6A3ABB4B74F4375B4D7C51733A2996
Jul 28, 2026
Merged

Dynamic config and file_transfer impl migration#246
rmaddikery merged 2 commits into
eclipse-score:mainfrom
Y-Vaishnavi:5A6A3ABB4B74F4375B4D7C51733A2996

Conversation

@Y-Vaishnavi

Copy link
Copy Markdown
Contributor

This migration guide describes necessary steps to replace the EES25 persistent caching concept with the EES30 central collection file concept.

GIT_ORIGIN_SPP_REV_ID: 7a9e0e247d1e69b39c6dbdf2a1c3c2531ded0297

Notes for Reviewer

Pre-Review Checklist for the PR Author

  • PR title is short, expressive and meaningful
  • Commits are properly organized
  • Relevant issues are linked in the References section
  • Tests are conducted
  • Unit tests are added

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  • All open points are addressed and tracked via issues

References

Closes #

@github-actions

github-actions Bot commented Jul 26, 2026

Copy link
Copy Markdown

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.6.0) and connecting to it...
INFO: Invocation ID: 991e6ee0-5db7-495b-bfcc-cdaef5857afd
Computing main repo mapping: 
Computing main repo mapping: 
WARNING: For repository 'score_process', the root module requires module version score_process@1.5.4, but got score_process@1.6.0 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'score_crates', the root module requires module version score_crates@0.0.9, but got score_crates@0.0.10 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 4 packages loaded
Loading: 4 packages loaded
    currently loading: 
Loading: 4 packages loaded
    currently loading: 
WARNING: Target pattern parsing failed.
ERROR: Skipping '//:license-check': no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/logging/logging/BUILD
ERROR: no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/logging/logging/BUILD
INFO: Elapsed time: 9.714s
INFO: 0 processes.
ERROR: Build did NOT complete successfully
ERROR: Build failed. Not running target

@Y-Vaishnavi
Y-Vaishnavi force-pushed the 5A6A3ABB4B74F4375B4D7C51733A2996 branch from 1566978 to d418fce Compare July 27, 2026 06:08
@Y-Vaishnavi Y-Vaishnavi changed the title config_mgmt migration ees30 CW_30 export: dynamic config and file_transfer impl migration Jul 27, 2026
@Y-Vaishnavi
Y-Vaishnavi marked this pull request as ready for review July 27, 2026 09:17
@Y-Vaishnavi Y-Vaishnavi changed the title CW_30 export: dynamic config and file_transfer impl migration Dynamic config and file_transfer impl migration Jul 27, 2026
When file_transfer=True, the datarouter_feature_config.h includes
filetransfer_stream.h which only has log_level.h. This was missing
the LogError and LogInfo declarations that dlt_log_server.cpp uses.

When file_transfer=False, the stub header provided logging.h
transitively, masking the missing include.

This fix adds a direct include of score/mw/log/logging.h to make
the source file self-sufficient regardless of feature flag state.

Tested with file_transfer=True/False and enable_dynamic_configuration=True/False.
@Y-Vaishnavi
Y-Vaishnavi force-pushed the 5A6A3ABB4B74F4375B4D7C51733A2996 branch from 0e8b4b6 to 1cfa72c Compare July 28, 2026 10:30
@Y-Vaishnavi
Y-Vaishnavi deployed to workflow-approval July 28, 2026 10:30 — with GitHub Actions Active
@Y-Vaishnavi
Y-Vaishnavi temporarily deployed to workflow-approval July 28, 2026 10:30 — with GitHub Actions Inactive
@Y-Vaishnavi
Y-Vaishnavi temporarily deployed to workflow-approval July 28, 2026 10:30 — with GitHub Actions Inactive
@github-project-automation github-project-automation Bot moved this from Backlog to On Hold in LOG - Logging FT Jul 28, 2026
@rmaddikery
rmaddikery merged commit 92a3b95 into eclipse-score:main Jul 28, 2026
19 of 20 checks passed
@github-project-automation github-project-automation Bot moved this from On Hold to Done in LOG - Logging FT Jul 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants