Carve FixedSizeQueue out of MpscBoundedQueue by paulquiring · Pull Request #367 · eclipse-score/lifecycle

paulquiring · 2026-07-24T12:06:20Z

Carve FixedSizeQueue out of MpscBoundedQueue for reuse.
MpscBoundedQueues capacity can be set now at runtime, to allow
setting the capacity based on configuration.

github-actions · 2026-07-24T12:07:07Z

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output

[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.6.0) and connecting to it...
INFO: Invocation ID: ca3c3c0a-6918-4cc6-be86-926740c205f6
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //:license-check (36 packages loaded, 10 targets configured)

Analyzing: target //:license-check (85 packages loaded, 10 targets configured)

Analyzing: target //:license-check (111 packages loaded, 92 targets configured)

Analyzing: target //:license-check (151 packages loaded, 2796 targets configured)

Analyzing: target //:license-check (156 packages loaded, 5498 targets configured)

Analyzing: target //:license-check (156 packages loaded, 5498 targets configured)

Analyzing: target //:license-check (161 packages loaded, 5547 targets configured)

Analyzing: target //:license-check (161 packages loaded, 5547 targets configured)

Analyzing: target //:license-check (164 packages loaded, 7434 targets configured)

Analyzing: target //:license-check (166 packages loaded, 10255 targets configured)

Analyzing: target //:license-check (168 packages loaded, 10283 targets configured)

Analyzing: target //:license-check (168 packages loaded, 10283 targets configured)

Analyzing: target //:license-check (168 packages loaded, 10283 targets configured)

Analyzing: target //:license-check (168 packages loaded, 10283 targets configured)

INFO: Analyzed target //:license-check (169 packages loaded, 10409 targets configured).
[14 / 16] [Prepa] JavaToolchainCompileBootClasspath external/rules_java+/toolchains/platformclasspath.jar
[15 / 16] Building license.check.license_check.jar (); 0s disk-cache, multiplex-worker
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 28.479s, Critical Path: 2.42s
INFO: 16 processes: 12 internal, 3 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 16 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

github-actions · 2026-07-24T12:17:44Z

The created documentation from the pull request is available at: docu-html

WilliamRoebuck

Looks good overall, only minor comments

NicolasFussberger · 2026-07-24T12:31:34Z

Should we move this out to a separate file if it is a reusable container?

paulquiring · 2026-07-27T09:05:26Z

Should we move this out to a separate file if it is a reusable container?

fixed in last commit

NicolasFussberger · 2026-07-27T13:27:39Z

+#include <optional>
+#include <vector>
+
+#include <score/assert.hpp>


include required?

removed in latest commit

NicolasFussberger · 2026-07-27T13:28:50Z

+                                  "size() returns 0 " 
+                                  "capacity() returns 0 "
+                                  "push returns false "
+                                  "tryPop() turns std::nullopt"); 


Suggested change

"tryPop() turns std::nullopt");

"tryPop() returns std::nullopt");

fixed in latest commit

NicolasFussberger · 2026-07-27T13:29:59Z

+    while(!queue_cap_five.full()) {
+        EXPECT_TRUE(queue_cap_five.push(1));
+        ++no_elements;
+        RecordProperty("Description", "Verify that push increments the size by one."); 


Can RecordProperty with Description actually be used multiple times in the same test?
I would have thought this overwrites the previous description

fixed in latest commit

NicolasFussberger · 2026-07-27T13:37:05Z

+#include <vector>
+
+using namespace score::lcm::internal;
+


I think we'll need to add RecordProperty for TestType and DerivationTechnique.
See https://eclipse-score.github.io/process_description//main/process_areas/verification/guidance/verification_templates.html#c-properties-template

fixed in latest commit

Carve FixedSizeQueue out of MpscBoundedQueue

d032bec

github-project-automation Bot added this to LCM - Lifecycle & Health FT Jul 24, 2026

github-project-automation Bot moved this to Backlog in LCM - Lifecycle & Health FT Jul 24, 2026

paulquiring temporarily deployed to workflow-approval July 24, 2026 12:06 — with GitHub Actions Inactive

paulquiring requested a review from WilliamRoebuck July 24, 2026 12:12

paulquiring commented Jul 24, 2026

View reviewed changes

Comment thread score/launch_manager/src/daemon/src/common/concurrency/mpsc_bounded_queue.hpp Outdated

paulquiring commented Jul 24, 2026

View reviewed changes

Comment thread score/launch_manager/src/daemon/src/common/concurrency/mpsc_bounded_queue.hpp Outdated

WilliamRoebuck approved these changes Jul 24, 2026

View reviewed changes

WilliamRoebuck reviewed Jul 24, 2026

View reviewed changes

Comment thread score/launch_manager/src/daemon/src/common/concurrency/mpsc_bounded_queue.hpp Outdated

anmittag assigned paulquiring Jul 24, 2026

Apply suggestions from review

89955ba

paulquiring requested a deployment to workflow-approval July 27, 2026 09:02 — with GitHub Actions Waiting

paulquiring requested a review from NicolasFussberger July 27, 2026 09:07

NicolasFussberger reviewed Jul 27, 2026

View reviewed changes

Apply suggestions from reviewer

98407da

paulquiring requested a deployment to workflow-approval July 27, 2026 17:55 — with GitHub Actions Waiting

	"tryPop() turns std::nullopt");
	"tryPop() returns std::nullopt");

Uh oh!

Conversation

paulquiring commented Jul 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

License Check Results

Uh oh!

Uh oh!

github-actions Bot commented Jul 24, 2026

Uh oh!

Uh oh!

WilliamRoebuck left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

NicolasFussberger commented Jul 24, 2026

Uh oh!

Uh oh!

paulquiring commented Jul 27, 2026

Uh oh!

NicolasFussberger Jul 27, 2026

Choose a reason for hiding this comment

Uh oh!

paulquiring Jul 27, 2026

Choose a reason for hiding this comment

Uh oh!

NicolasFussberger Jul 27, 2026

Choose a reason for hiding this comment

Uh oh!

paulquiring Jul 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

NicolasFussberger Jul 27, 2026

Choose a reason for hiding this comment

Uh oh!

paulquiring Jul 27, 2026

Choose a reason for hiding this comment

Uh oh!

NicolasFussberger Jul 27, 2026

Choose a reason for hiding this comment

Uh oh!

paulquiring Jul 27, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

paulquiring commented Jul 24, 2026 •

edited

Loading

github-actions Bot commented Jul 24, 2026 •

edited

Loading

paulquiring Jul 27, 2026 •

edited

Loading