Run integration tests on QNX via QEMU - #328
Open
danth wants to merge 6 commits into
Open
Conversation
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
This comment was marked as outdated.
This comment was marked as outdated.
MaciejKaszynski
requested changes
Jul 24, 2026
| - bazel-config: x86_64-qnx | ||
| bazel-test-target: >- | ||
| //score/... | ||
| bazel-test-target: //examples/... //tests/... |
Contributor
There was a problem hiding this comment.
It would be good to merge the unit tests and other tests into a single entry so that we utilize the cache more.
Member
Author
There was a problem hiding this comment.
Right now they need to be run with separate configs so that would have to be resolved first.
2 tasks
Our Bazel toolchain for Python does not work with QNX, so we need to use built-in libraries to parse the results instead.
With proper use of Bazel platforms rather than configs, I think it would be possible to do this in a much cleaner way. However that would require deeper changes across our codebase and possibly in the test frameworks as well.
MaciejKaszynski
requested changes
Jul 24, 2026
MaciejKaszynski
approved these changes
Jul 24, 2026
| f"LCM did not exit cleanly, it died with code {proc.get_exit_code()}" | ||
| ) | ||
| assert res == 0, "Couldn't kill lcm" | ||
| proc.stop() |
Contributor
There was a problem hiding this comment.
Can we still check the exit code here?
In the past I had some test where LCM did crash during shutdown and the test still showed success before the exit code got checked.
| test:x86_64-qnx --test_lang_filters=cc,rust | ||
| build:x86_64-qnx --define config=x86_64-qnx | ||
|
|
||
| build:unit-tests-x86_64-qnx --config=x86_64-qnx |
Contributor
There was a problem hiding this comment.
Could you extend the Readme at "Getting Started.Building" to show how to run the unit test and integration tests for the different targets?
Might be good to document if we are deviating from the default config.
NicolasFussberger
requested changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #316.
Outstanding issues:
--configargument is now needed to run unit tests, as otherwise the unit test framework adds an unwanted second layer of emulation to the integration tests. Since they are using--run_underit is difficult to avoid this.Some of these could be tackled in future PRs.