refactor(quality): rework compiler-warning cc_features and fix flag placement - #765
Merged
castler merged 1 commit intoJul 27, 2026
Merged
Conversation
AAmbuj
force-pushed
the
amsh_refactor_compiler_warnings
branch
from
July 24, 2026 11:10
9a8cfb3 to
3d47478
Compare
AAmbuj
marked this pull request as ready for review
July 24, 2026 11:10
AAmbuj
requested review from
LittleHuba,
bemerybmw,
castler,
crimson11,
hoe-jo and
limdor
as code owners
July 24, 2026 11:10
castler
reviewed
Jul 27, 2026
Comment on lines
+41
to
+42
| "-D_QNX_SOURCE", | ||
| "-D_XOPEN_SOURCE=700", # SUSv4 (POSIX.1-2008 base specification plus the XSI extension) |
Contributor
There was a problem hiding this comment.
Why would we set this? This should come from QCC, and not be set by us manually.
Comment on lines
-51
to
-55
| # Demote shadow-uncaptured-local from error to warning. This diagnostic | ||
| # fires for code in external headers (e.g. score_baselibs simple_task.h) | ||
| # which we cannot fix. | ||
| # raised a ticket in score_baselibs to fix this issue, but for now we demote it to warning | ||
| # Bug ticket: (https://github.com/eclipse-score/baselibs/issues/304) |
Contributor
There was a problem hiding this comment.
Why removing this explanation comment?
Contributor
Author
There was a problem hiding this comment.
its fixed! in the baselibs
AAmbuj
force-pushed
the
amsh_refactor_compiler_warnings
branch
5 times, most recently
from
July 27, 2026 09:46
291e3e5 to
62df7a9
Compare
castler
previously approved these changes
Jul 27, 2026
castler
enabled auto-merge
July 27, 2026 09:59
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 27, 2026
castler
added
the
test-qnx
castler
temporarily deployed
to
workflow-approval
July 27, 2026 10:32 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
AAmbuj
force-pushed
the
amsh_refactor_compiler_warnings
branch
from
July 27, 2026 10:37
62df7a9 to
4e89e2d
Compare
AAmbuj
force-pushed
the
amsh_refactor_compiler_warnings
branch
2 times, most recently
from
July 27, 2026 10:53
68049b3 to
07ae26c
Compare
AAmbuj
force-pushed
the
amsh_refactor_compiler_warnings
branch
from
July 27, 2026 12:22
07ae26c to
951c002
Compare
AAmbuj
force-pushed
the
amsh_refactor_compiler_warnings
branch
from
July 27, 2026 12:23
951c002 to
4e5a8c0
Compare
AAmbuj
force-pushed
the
amsh_refactor_compiler_warnings
branch
from
July 27, 2026 14:22
4e5a8c0 to
5e22419
Compare
…lacement Restructure the score_communication compiler-warning toolchain features so they are correct, toolchain-aware, and duplication-free. - MODULE.bazel: repoint to //quality/compiler_warnings/clang:default_flags and clang:additional_warnings; remove the stale :default_flags / :default_link_flags refs that broke all cc analysis. Keep the raw SCORE_GCC minimal baseline in sync with the gcc/ minimal feature. - Define the public features (minimal/strict/additional_warnings) per toolchain in clang/ and gcc/, each implying a shared common base, so requesting a feature yields the full toolchain-specific flag set. - Place every flag by compiler (verified by probing gcc/clang): GCC-only in gcc/, Clang-only in clang/, dual-support in common. Move -Wfloat-equal to common; move -Wno-deprecated-non-prototype to clang. - De-duplicate: drop -fstack-protector (superseded by -fstack-protector-strong); source -lrt/-latomic from the toolchain link_libs only. - Fix GCC -Wno-error= demotions (drop malformed level suffixes; restore the valid GCC-only -Wno-error=tsan) and prepend -Werror so the demotions in strict_warnings_no_error reliably take effect. - Add security-hardening compile/link defaults (_FORTIFY_SOURCE, RELRO+BIND_NOW, stack-clash-protection, CET/-fcf-protection). - Regenerate visibility_guard golden; sync test/README.md and quality.md.
AAmbuj
force-pushed
the
amsh_refactor_compiler_warnings
branch
from
July 27, 2026 15:07
5e22419 to
301a506
Compare
castler
approved these changes
Jul 27, 2026
castler
enabled auto-merge
July 27, 2026 17:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restructure the score_communication compiler-warning toolchain features so they are correct, toolchain-aware, and duplication-free.