Rust::com Move Rust Public API to com/rust by bharatGoswami8 · Pull Request #736 · eclipse-score/communication

bharatGoswami8 · 2026-07-21T10:31:32Z

Moves the Rust COM public API from the internal impl/rust/ folder to a proper public location at com/rust.

New targets created at rust (score_com, score_com_concept, score_com_macros, score_com_cpp_bridge)
- Old targets support is not there.
Internal type names prefixed with Lola/Mock to avoid clashes with public trait names (e.g. Publisher - LolaPublisher)
Docs and examples updated to reference the new paths
Golden file ordering for the visibility guard test
Changes from the original text: com_api - score_com.

castler · 2026-07-22T10:13:13Z

+//score/mw/com/rust/com-api-macros:com-api-macros
+//score/mw/com/rust/concept:concept
+//score/mw/com/rust/ffi_bridge:register_interface
+//score/mw/com/rust:api


IMHO it would be good to have only one crate here and we should name it:

//score/mw/com/rust:score_com

We actually really need this two

//score/mw/com/rust/ffi_bridge:register_interface (c++ bridge) //score/mw/com/rust:api (rust)

The other two targets are already imported by //score/mw/com/rust:api, so users can access them through that target.

Since both of these are part of the public interface, I kept their visibility as public.

Regarding the naming, we're already directly under the score/com folder, so I think using the name score_com is redundant.

I have updated quality/visibility_guard/public_targets.golden and target visibility.

Updated to //score/mw/com/rust:com_api

Updated to //score/mw/com/rust:score_com

rpreddyhv

Few early review finding

LittleHuba

Your migration aliases fall short. While they point to the right targets, the types in the targets were renamed.
I see two sensible ways forward:

Drop the aliases completely. We do not provide a migration path. This API was never communicated as stable to our users.
Provide actual migration shims where you not only alias the right bazel target but also alias all types within.

I'm fine with either as long as you don't do something in the middle.

bharatGoswami8 · 2026-07-23T09:37:08Z

Your migration aliases fall short. While they point to the right targets, the types in the targets were renamed. I see two sensible ways forward:

Drop the aliases completely. We do not provide a migration path. This API was never communicated as stable to our users.

Provide actual migration shims where you not only alias the right bazel target but also alias all types within.

I'm fine with either as long as you don't do something in the middle.

@LittleHuba , I think better to remove aliases, as we already notified on slack channel to adapt as per updated bazel target.

* Moved Concept crate in com/rust folder * Moved macro also in com/rust folder * Updated backward compatibility for all the moved target * Updated runtime struct according to concept changes

* Moved all the document into com/rust folder

* Added header for c++ rust bridge macro support

* Removed the impl public target * Updated design diagram naming * Updated com/rust folder naming

* Mock Runtime dependecy removed from production target

* Updated main crate name as score_crate * CPP macro target updated

github-project-automation Bot moved this to Backlog in COM - Communication FT Jul 21, 2026

github-project-automation Bot added this to COM - Communication FT Jul 21, 2026

bharatGoswami8 force-pushed the Rust_Public_API_Move_from_Impl branch 3 times, most recently from cfafd1d to 2834d35 Compare July 21, 2026 11:42

bharatGoswami8 self-assigned this Jul 21, 2026

bharatGoswami8 added the rust-api label Jul 21, 2026

bharatGoswami8 changed the title ~~Rust::com Move rust Public API to com/rust~~ Rust::com Move Rust Public API to com/rust Jul 21, 2026

bharatGoswami8 force-pushed the Rust_Public_API_Move_from_Impl branch from ba3f4cf to 816ba87 Compare July 21, 2026 16:43

bharatGoswami8 marked this pull request as ready for review July 21, 2026 16:45

bharatGoswami8 requested review from LittleHuba, bemerybmw, castler, crimson11, hoe-jo and limdor as code owners July 21, 2026 16:45

bharatGoswami8 requested a review from darkwisebear July 21, 2026 16:45

bharatGoswami8 mentioned this pull request Jul 21, 2026

Reduce bazel API surface #733

Merged

tejaswinijoshi89 approved these changes Jul 22, 2026

View reviewed changes

castler requested changes Jul 22, 2026

View reviewed changes

bharatGoswami8 mentioned this pull request Jul 22, 2026

Improvement: Move the Rust Sample example app from com/example to tutorial folder #741

Open

2 tasks

bharatGoswami8 requested a review from castler July 22, 2026 11:03

bharatGoswami8 force-pushed the Rust_Public_API_Move_from_Impl branch from 5c5d966 to 89c066f Compare July 22, 2026 13:02

rpreddyhv reviewed Jul 23, 2026

View reviewed changes

Comment thread score/mw/com/example/com-api-example/com-api-gen/vehicle_gen.cpp

Comment thread score/mw/com/rust/score_com_cpp_bridge/BUILD

Comment thread score/mw/com/rust/score_com_macros/lib.rs

Comment thread score/mw/com/example/com-api-example/BUILD Outdated

LittleHuba reviewed Jul 23, 2026

View reviewed changes

Comment thread score/mw/com/rust/BUILD

Comment thread score/mw/com/impl/rust/com-api/com-api-runtime-lola/runtime.rs

rpreddyhv reviewed Jul 23, 2026

View reviewed changes

Comment thread score/mw/com/rust/design/sequence_diagram/async_cancellable_receive_data.puml

bharatGoswami8 force-pushed the Rust_Public_API_Move_from_Impl branch from 09a3b4d to 3a14981 Compare July 23, 2026 09:29

bharatGoswami8 requested review from LittleHuba and rpreddyhv July 23, 2026 09:35

bharatGoswami8 added 15 commits July 24, 2026 14:29

Rust::com Move Rust Public APIs out of impl folder

adef99f

* Moved Concept crate in com/rust folder * Moved macro also in com/rust folder * Updated backward compatibility for all the moved target * Updated runtime struct according to concept changes

Rust::com Move the documentation on com/rust folder

9356451

* Moved all the document into com/rust folder

Rust::com Add C++ macro support in com/rust

cf3d5b1

* Added header for c++ rust bridge macro support

Rust::com Formatting update for rust files

064eec0

Rust::com Update the visibility_guard

988723f

Rust::com Added bridge macro in public scope mw/rust

25bc634

Rust::com Update example app with updated target

d57f8ac

Rust::com Update the integration test target

a3ad4aa

Rust::com Update the Unit test for LolaRuntime

5e78d1f

Rust::com update the proc-macro for rust

cee69f2

Rust::com Move rust public interface in com/rust

240a85c

Rust::com Update design and doc folder

0465fae

Rust::com update the main crate name to com_api

1423ec5

Rust::com Update the macro crate name

61b89d3

Rust::com Remove the impl public target

f8b19c9

* Removed the impl public target * Updated design diagram naming * Updated com/rust folder naming

bharatGoswami8 force-pushed the Rust_Public_API_Move_from_Impl branch from 33b07c0 to 5d64d21 Compare July 24, 2026 09:21

Rust::com create mock/test target for MockRuntime

bd5274e

* Mock Runtime dependecy removed from production target

bharatGoswami8 force-pushed the Rust_Public_API_Move_from_Impl branch 6 times, most recently from d043f58 to 4917621 Compare July 27, 2026 04:16

Rust::com score_com crate updated

f15e1dd

* Updated main crate name as score_crate * CPP macro target updated

bharatGoswami8 force-pushed the Rust_Public_API_Move_from_Impl branch from 4917621 to f15e1dd Compare July 27, 2026 04:20

castler approved these changes Jul 27, 2026

View reviewed changes

castler added this pull request to the merge queue Jul 27, 2026

Merged via the queue into eclipse-score:main with commit b72c3d9 Jul 27, 2026
8 checks passed

github-project-automation Bot moved this from Backlog to Done in COM - Communication FT Jul 27, 2026

Uh oh!

Conversation

bharatGoswami8 commented Jul 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

castler Jul 22, 2026

Choose a reason for hiding this comment

Uh oh!

bharatGoswami8 Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bharatGoswami8 Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bharatGoswami8 Jul 22, 2026

Choose a reason for hiding this comment

Uh oh!

bharatGoswami8 Jul 27, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

rpreddyhv left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

LittleHuba left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bharatGoswami8 commented Jul 23, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

bharatGoswami8 commented Jul 21, 2026 •

edited

Loading

bharatGoswami8 Jul 22, 2026 •

edited

Loading

bharatGoswami8 Jul 22, 2026 •

edited

Loading