Rust::com Field APIs design and example of usage#700
Open
bharatGoswami8 wants to merge 11 commits into
Open
Conversation
* Created field interface APIs * Updated SampleMut to use in field as well
* Added field related files on build target
* Created impl block in Lola Runtime for field Producer and Consumer trait
* Mock Runtime impl block added for field APIs
* Updated Interface macro to generate field related types and APIs
* Create proc macro for field init and set handler validation before offer call
* Updated Runtime GATs for field public types * Updated Runtime implementation
* Updated example file with Field APIs usage
bharatGoswami8
requested review from
LittleHuba,
bemerybmw,
castler,
crimson11,
hoe-jo and
limdor
as code owners
July 14, 2026 05:41
bharatGoswami8
force-pushed
the
Rust_Field_APIs_Desing_and_Example
branch
2 times, most recently
from
July 14, 2026 05:45
70fbb6e to
f7cd859
Compare
bharatGoswami8
commented
Jul 14, 2026
| /// "left_tire" and "exhaust" events. | ||
| /// - `VehicleOfferedProducer<R>` struct that implements `OfferedProducer` trait for offering | ||
| /// "left_tire" and "exhaust" events. | ||
| // TODO: We need to enable the support for mixed types (Event, Method, Field) in the same interface definition. |
* Updated the TODOs and documentation
bharatGoswami8
force-pushed
the
Rust_Field_APIs_Desing_and_Example
branch
2 times, most recently
from
July 14, 2026 06:11
6921668 to
6faaa6c
Compare
* Clone bound removed from fieldPublisher trait and impl block
bharatGoswami8
force-pushed
the
Rust_Field_APIs_Desing_and_Example
branch
from
July 14, 2026 06:23
6faaa6c to
21d958d
Compare
* Producer trait offer API limitation added to avoid direct use
bharatGoswami8
force-pushed
the
Rust_Field_APIs_Desing_and_Example
branch
from
July 19, 2026 08:53
30e0af1 to
8589c65
Compare
rpreddyhv
reviewed
Jul 24, 2026
Comment on lines
+191
to
+195
| // Below function just demonstrate the field APIs usage | ||
| // This build fine but it can not run because we have not implemented the field APIs in Lola runtime yet. | ||
|
|
||
| // Producer creation and intialization of fields with initial values and set handlers for the fields | ||
| // It will return the offered producer instance which can be used to update the fields. |
There was a problem hiding this comment.
Suggested change
| // Below function just demonstrate the field APIs usage | |
| // This build fine but it can not run because we have not implemented the field APIs in Lola runtime yet. | |
| // Producer creation and intialization of fields with initial values and set handlers for the fields | |
| // It will return the offered producer instance which can be used to update the fields. | |
| // Below function demonstrate the field APIs usage | |
| // This builds fine, but it cannot run as the field APIs in Lola runtime are not implemented yet. | |
| // Producer creation and intialization of fields with initial values and set handlers for the fields | |
| // It will return the offered producer instance which can be used to update the fields. |
| // TODO: in working example add that logic to demonstrate the set handler usage. | ||
| // Note: I think producer may be need clone ? | ||
| }) | ||
| .expect("Failed to register set handlers") |
There was a problem hiding this comment.
Why would register_* ever fail? As discussed for Method, it shouldn't return Result.
| .register_set_handler_left_tire(move |val: &Tire| { | ||
| println!("Received tire pressure update: {:?}", val); | ||
| // Additional logic to handle the tire pressure update can be added here | ||
| // For example, we can increment value or conver unit and update the field again. |
There was a problem hiding this comment.
Suggested change
| // For example, we can increment value or conver unit and update the field again. | |
| // For example, we can increment value or convert unit and update the field again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#579