Support unified diff for version history entries - #2935
Open
tobiasmelcher wants to merge 1 commit into
Open
tobiasmelcher wants to merge 1 commit into
tobiasmelcher wants to merge 1 commit into
Conversation
Contributor
Test Results 54 files ±0 54 suites ±0 57m 17s ⏱️ - 2m 17s Results for commit 5fd575c. ± Comparison against base commit 2d15cf3. This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both. |
Contributor
|
There is a comment in CompareUIPlugin.java:928: "an editor opened on anything else, a revision for example, comes up empty." With this change that is not true anymore and the comment should be updated. Also the scope seem wider than "version history entries", as the commit message indicates. I think it will also work for index-vs-HEAD comparisons (I did not test this). |
Contributor
|
Otherwise a great change! Thanks @tobiasmelcher |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comparing two entries in the Eclipse History view currently falls back to the classic side-by-side compare editor, even when unified diff is enabled. Both historical revisions are represented by storage-backed editor inputs, which were not eligible for unified diff.
This change recognizes a pair of revision storage inputs and opens the right-hand revision in a read-only editor with the left-hand revision overlaid as the diff. This brings revision-to-revision comparisons into the unified diff workflow while preserving historical content as non-editable.