Fix flaky ensureCleanUpAddonCleansUp test#3786
Open
vogella wants to merge 2 commits intoeclipse-platform:masterfrom
Open
Fix flaky ensureCleanUpAddonCleansUp test#3786vogella wants to merge 2 commits intoeclipse-platform:masterfrom
vogella wants to merge 2 commits intoeclipse-platform:masterfrom
Conversation
This reverts commit 54b8aa2.
Add spinEventLoop() between the two hidePart() calls to drain pending events before the second hide. This ensures a clean event queue when CleanupAddon's asyncExec is queued for visCount==0, replacing the 30-second DisplayHelper.waitForCondition polling with a deterministic event drain. Fixes eclipse-platform#3581
Contributor
Author
|
Next try to stabilize the test, based on the revert from @trancexpress (will rebase once the revert is merged). |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
spinEventLoop()between the twohidePart()calls to drain pending events before the second hideasyncExecis queued forvisCount==0DisplayHelper.waitForConditionpolling with a deterministic event drainDisplayHelperimportDepends on #3785 (revert of the synchronous cleanup change)
Test plan
ensureCleanUpAddonCleansUppasses consistently (no longer flaky)Fixes #3581
🤖 Generated with Claude Code