Limit monitor-specific scaling to supported autoscale modes

[ShahzaibIbrahim]

These changes have following affects:

• Upon starting eclipse product when monitor-specific scaling is set with unsupported autoscale mode, it will show a error dialog and application won't start.
• User won't be able to enable monitor-specific scaling from appearance page if unsupported autoscale mode is set from property or ini file.
• User can then either force the unsupported autoscale mode with monitor specific-scaling by setting swt.autoScale.force to true or switch to supported autoscale mode.

Testing

---

Scenario#1: Starting application with -Dswt.autoScale=int200

Result: App should start (if monitor-specific scaling is not checked in Appearance page), but option to turn on monitor-specific scaling in Appearance page should be disabled.

---

Scenario#2: Starting application with -Dswt.autoScale=int200 and -Dswt.autoScale.updateOnRuntime=true

Result: App will start, user will see an error dialog stating the incompatibility of an option and monitor specific-scaling will be disabled.

---

Scenario#3: Starting application with -Dswt.autoScale=int200 and -Dswt.autoScale.updateOnRuntime=true
and -Dswt.autoScale.force=true

Result: makes more sense with swt applications. if user really wants to use other scaling mode with monitor-specific scaling.

import org.eclipse.swt.widgets.*;

public class AutoScaleSnippet {

public static void main (String [] args) {
	System.setProperty("swt.autoScale.updateOnRuntime", "true");
	System.setProperty("swt.autoScale", "int200");
	System.setProperty("swt.autoScale.force", "true");
	Display display = new Display ();
	Shell shell = new Shell(display);
	shell.setText("Autoscale snippet");
	shell.open ();
	while (!shell.isDisposed ()) {
		if (!display.readAndDispatch ()) display.sleep ();
	}
	display.dispose ();
}

---

Scenario#4: Starting application with -Dswt.autoScale=quarter

Result: App should start, and user should be able to turn on/off the monitor-specific scaling in Appearance page.

---

Note: following is the list of allowed autoscale values to be paired with monitor-specific scaling: ["false", "quarter", "exact"] or any concrete zoom value e.g. 225

Dependency

• Requires: [Refactor] Moving methods from Win32DPIUtil to DPIUtil for autoscaling eclipse.platform.swt#2709

[github-actions]

Test Results

 4 files   -  3 014   4 suites   - 3 014   1s ⏱️ - 2h 17m 18s
24 tests  -  8 210  24 ✅  -  7 961  0 💤  - 249  0 ❌ ±0 
48 runs   - 23 574  48 ✅  - 22 780  0 💤  - 794  0 ❌ ±0 

Results for commit b430848. ± Comparison against base commit a3fa065.

This pull request removes 8210 tests.

AllFormsTests AllEventsTests ExpansionListenerTest ‑ callsExpansionStateChangedConsumer
AllFormsTests AllEventsTests ExpansionListenerTest ‑ callsExpansionStateChangingConsumer
AllFormsTests AllEventsTests ExpansionListenerTest ‑ throwsNullPointerOnNullStateChangedAdapter
AllFormsTests AllEventsTests ExpansionListenerTest ‑ throwsNullPointerOnNullStateChangingAdapter
AllFormsTests AllEventsTests HyperLinkListenerTest ‑ callsActivatedConsumer
AllFormsTests AllEventsTests HyperLinkListenerTest ‑ callsEnteredConsumer
AllFormsTests AllEventsTests HyperLinkListenerTest ‑ callsExitedConsumer
AllFormsTests AllEventsTests HyperLinkListenerTest ‑ throwsNullPointerOnNullActivatedAdapter
AllFormsTests AllEventsTests HyperLinkListenerTest ‑ throwsNullPointerOnNullEnteredAdapter
AllFormsTests AllEventsTests HyperLinkListenerTest ‑ throwsNullPointerOnNullExitedAdapter
…

♻️ This comment has been updated with latest results.

[ShahzaibIbrahim]

Test failures are due to dependent PR: eclipse-platform/eclipse.platform.swt#2709 not being merged yet.

[amartya4256]

I have tested the PR and it seems good to me. Approving.

[HeikoKlare]

This should be deferred to when the workbench has been started, so that the dialog can be created on top of the workbench instead of creating a new shell on the default display. In particular because at this point in time the display for the workbench is not initialized yet, so this may have unintended side effects.