Skip to content

[Gtk4] Clip Composite children to parent bounds #3324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
akurtakov wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[Gtk4] Clip Composite children to parent bounds #3324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8dcc9b
[Gtk4] Clip Composite children to parent bounds
akurtakov May 25, 2026
a2c6ae1
Clarify comment from review
akurtakov May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions bundles/org.eclipse.swt/Eclipse SWT PI/gtk/library/gtk4.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2829,6 +2829,16 @@ JNIEXPORT void JNICALL GTK4_NATIVE(gtk_1widget_1set_1focusable)
}
#endif

#ifndef NO_gtk_1widget_1set_1overflow
JNIEXPORT void JNICALL GTK4_NATIVE(gtk_1widget_1set_1overflow)
(JNIEnv *env, jclass that, jlong arg0, jint arg1)
{
GTK4_NATIVE_ENTER(env, that, gtk_1widget_1set_1overflow_FUNC);
gtk_widget_set_overflow((GtkWidget *)arg0, (GtkOverflow)arg1);
GTK4_NATIVE_EXIT(env, that, gtk_1widget_1set_1overflow_FUNC);
}
#endif

#ifndef NO_gtk_1widget_1set_1size_1request
JNIEXPORT void JNICALL GTK4_NATIVE(gtk_1widget_1set_1size_1request)
(JNIEnv *env, jclass that, jlong arg0, jint arg1, jint arg2)
Expand Down
1 change: 1 addition & 0 deletions bundles/org.eclipse.swt/Eclipse SWT PI/gtk/library/gtk4_stats.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,6 +230,7 @@ typedef enum {
gtk_1widget_1pick_FUNC,
gtk_1widget_1set_1cursor_FUNC,
gtk_1widget_1set_1focusable_FUNC,
gtk_1widget_1set_1overflow_FUNC,
gtk_1widget_1set_1size_1request_FUNC,
gtk_1widget_1size_1allocate_FUNC,
gtk_1widget_1snapshot_1child_FUNC,
Expand Down
8 changes: 8 additions & 0 deletions bundles/org.eclipse.swt/Eclipse SWT PI/gtk/org/eclipse/swt/internal/gtk4/GTK4.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@ public class GTK4 {
public static final int GTK_EVENT_SEQUENCE_CLAIMED = 1;
public static final int GTK_EVENT_SEQUENCE_DENIED = 2;

public static final int GTK_OVERFLOW_VISIBLE = 0;
public static final int GTK_OVERFLOW_HIDDEN = 1;

public static final int GTK_PICK_DEFAULT = 0;
public static final int GTK_PICK_INSENSITIVE = 1;
public static final int GTK_PICK_NON_TARGETABLE = 2;
Expand Down Expand Up @@ -707,6 +710,11 @@ public class GTK4 {
* @param focusable cast=(gboolean)
*/
public static final native void gtk_widget_set_focusable(long widget, boolean focusable);
/**
* @param widget cast=(GtkWidget *)
* @param overflow cast=(GtkOverflow)
*/
public static final native void gtk_widget_set_overflow(long widget, int overflow);
/** @param widget cast=(GtkWidget *) */
public static final native long gtk_widget_get_clipboard(long widget);
/**
Expand Down
5 changes: 5 additions & 0 deletions bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Composite.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,6 +343,11 @@ void createHandle (int index, boolean fixed, boolean scrolled) {

if (GTK.GTK4) {
GTK4.gtk_widget_set_focusable(handle, true);
/*
* Without GTK_OVERFLOW_HIDDEN, children can draw freely outside the parent.
* With GTK_OVERFLOW_HIDDEN we reproduce the GTK3 clipping behaviour.
*/
GTK4.gtk_widget_set_overflow(handle, GTK4.GTK_OVERFLOW_HIDDEN);
} else {
GTK3.gtk_widget_set_has_window(handle, true);
}
Expand Down
Loading