[Gtk4] Fix Button image size by using GtkPicture instead of GtkImage#3323
Open
akurtakov wants to merge 1 commit into
Open
[Gtk4] Fix Button image size by using GtkPicture instead of GtkImage#3323akurtakov wants to merge 1 commit into
akurtakov wants to merge 1 commit into
Conversation
Gtk 4 works in logical points while Cairo works in pixel thus this is needed for proper size of the pixbuf scale to the original image size. This makes Button consistent with Label, which already uses GtkPicture for the same reason (see commit eclipse-platform#2766 ). Also fix a memory leak in Label where the GdkTexture created by gdk_texture_new_for_pixbuf() was not unreffed after being handed to gtk_picture_set_paintable().
Member
Author
|
Before: |
Contributor
akurtakov
added a commit
to akurtakov/eclipse.platform.swt
that referenced
this pull request
May 26, 2026
GTK4 works in logical points while Cairo works in pixels, causing images to appear smaller at HiDPI scaling. Using GtkPicture (instead of GtkImage) correctly maps the pixbuf to the right display size. This is the same fix applied to Button (eclipse-platform#3323 ) and Label (eclipse-platform#2766 ) for the same reason.
jonahgraham
approved these changes
May 26, 2026
Contributor
jonahgraham
left a comment
jonahgraham
left a comment
There was a problem hiding this comment.
Approved (for when master reopens)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gtk 4 works in logical points while Cairo works in pixel thus this is needed for proper size of the pixbuf scale to the original image size.
This makes Button consistent with Label, which already uses GtkPicture for the same reason (see commit
#2766 ).
Also fix a memory leak in Label where the GdkTexture created by gdk_texture_new_for_pixbuf() was not unreffed after being handed to gtk_picture_set_paintable().