[Cocoa] Fix in-place editor freeze by forcing TextKit 1#3321
Open
buchen wants to merge 1 commit into
Open
Conversation
On macOS the AppKit field editor SWT wraps can freeze during mouseDown: due to a TextKit 2 bug (_bellerophonTrack...). Accessing an NSTextView's layoutManager forces a permanent downgrade to TextKit 1 for that view. Force this downgrade eagerly at field-editor promotion time, before any mouse interaction, rather than relying on the existing lazy layoutManager() calls in getCaretLocation() which run too late: - Shell.createHandle(): the per-window field editor (SWTEditorView), covering SWT.SINGLE Text and editable Combo. - Text.createWidget(): the separate secure field editor for SWT.PASSWORD (SWTSecureEditorView). See eclipse-platform/eclipse.platform.ui#1069
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On macOS the AppKit field editor SWT wraps can freeze during mouseDown: due to a TextKit 2 bug (_bellerophonTrack...). Accessing an NSTextView's layoutManager forces a permanent downgrade to TextKit 1 for that view.
Force this downgrade eagerly at field-editor promotion time, before any mouse interaction, rather than relying on the existing lazy layoutManager() calls in getCaretLocation() which run too late:
See eclipse-platform/eclipse.platform.ui#1069