Skip to content

[MQTTv5] Enable use of Java's try-with-resources statement #1055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
a-st wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

[MQTTv5] Enable use of Java's try-with-resources statement #1055

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9e8ed84
added a testcase and fixed Issue-918
marco-kaeferbeck Apr 22, 2022
c06adb8
Merge pull request #948 from eclipse/develop
Aug 6, 2022
5d7dc22
Merge pull request #926 from marco-kaeferbeck/bugfix/Issue-918_topic_…
Aug 6, 2022
aa69bcc
Merge pull request #949 from eclipse/develop
Aug 6, 2022
f4e0db8
Merge pull request #950 from eclipse/develop
Aug 6, 2022
9c742c1
Add security info file as required by Eclipse processes
icraggs Jan 19, 2024
0ec53db
[MQTTv5] Enable use of Java's try-with-resources statement
a-st Aug 14, 2024
76a11f2
Merge branch 'eclipse-paho:master' into mqttv5-autoclosable
a-st Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ....mqttv5.client.test/src/test/java/org/eclipse/paho/mqttv5/common/utils/MqttTopicTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ public void testMatchedTopicFilterWildcards() throws Exception {
String[][] matchingTopics = new String[][] { { "sport/tennis/player1/#", "sport/tennis/player1" },
{ "sport/tennis/player1/#", "sport/tennis/player1/ranking" },
{ "sport/tennis/player1/#", "sport/tennis/player1/score/wimbledon" }, { "sport/#", "sport" },
{ "#", "sport/tennis/player1" } };
{ "#", "sport/tennis/player1" } , {"sport/+/player1/ranking/#","sport/tennis/player1/ranking"} };

for (String[] pair : matchingTopics) {
Assert.assertTrue(pair[0] + " should match " + pair[1], MqttTopicValidator.isMatched(pair[0], pair[1]));
Expand Down
2 changes: 1 addition & 1 deletion ...pse.paho.mqttv5.client/src/main/java/org/eclipse/paho/mqttv5/client/IMqttAsyncClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
import org.eclipse.paho.mqttv5.common.MqttSubscription;
import org.eclipse.paho.mqttv5.common.packet.MqttProperties;

public interface IMqttAsyncClient {
public interface IMqttAsyncClient extends AutoCloseable {

/**
* Connects to an MQTT server using the default options.
Expand Down
2 changes: 1 addition & 1 deletion org.eclipse.paho.mqttv5.client/src/main/java/org/eclipse/paho/mqttv5/client/IMqttClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
* style. The blocking client provides compatibility with earlier versions
* of the MQTT client.</p>
*/
public interface IMqttClient { //extends IMqttAsyncClient {
public interface IMqttClient extends AutoCloseable { //extends IMqttAsyncClient {
/**
* Connects to an MQTT server using the default options.
* <p>The default options are specified in {@link MqttConnectionOptions} class.
Expand Down
2 changes: 1 addition & 1 deletion ...aho.mqttv5.client/src/main/java/org/eclipse/paho/mqttv5/client/MqttClientPersistence.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
* It is up to the persistence interface to log any exceptions or error information
* which may be required when diagnosing a persistence failure.</p>
*/
public interface MqttClientPersistence {
public interface MqttClientPersistence extends AutoCloseable {
/**
* Initialise the persistent store.
* If a persistent store exists for this client ID then open it, otherwise
Expand Down
Loading