Repository navigation
build: AssertJ with the Byte Buddy it needs; MariaDB Connector/J 3.5.11 - #83
Merged
Merged
Conversation
Dependabot raised AssertJ to 3.27.7 in the root pom and in jdbc/impl. AssertJ 3.27 imports net.bytebuddy from 1.18 on, but the parent pom manages Byte Buddy 1.17.5, so the OSGi test runs of jdbc/impl and guard/jsqltranspiler could not resolve AssertJ and failed on main. The root pom and jdbc/pom.xml, whose parent is the daanse parent pom, now set the two side by side: AssertJ 3.27.7 and Byte Buddy 1.18.3, the version AssertJ is built against. jdbc/impl takes AssertJ from there instead of naming its own version. Signed-off-by: Stefan Bischof <stbischof@bipolis.org>
Connector/J before 3.4.5 has several advisories, among them a rogue server driving large heap allocations from lengths it declares in OK packets; jdbc/metadata used 3.4.3. Both test dependencies on the driver now take 3.5.11, the latest 3.x. Signed-off-by: Stefan Bischof <stbischof@bipolis.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main is red since AssertJ 3.27.7 came in, and Dependabot reports MariaDB Connector/J 3.4.3.
AssertJ and Byte Buddy
net.bytebuddyfrom 1.18 on. The parent pom manages Byte Buddy 1.17.5, so the OSGi test runs ofjdbc/implandguard/jsqltranspilercould not resolve AssertJ.jdbc/pom.xml, whose parent is the daanse parent pom, now set the two side by side: AssertJ 3.27.7 and Byte Buddy 1.18.3, the version AssertJ is built against.jdbc/impltakes AssertJ from there.MariaDB Connector/J
jdbc/metadataused 3.4.3, which the advisories fixed in 3.4.5 cover. It anddialect/db/mariadbnow take 3.5.11, the latest 3.x.